Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Unified Diff: components/autofill/core/browser/personal_data_manager_unittest.cc

Issue 2534413006: [Credit Card] Uses 4 dots in ellipsis (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/autofill/core/browser/credit_card_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/core/browser/personal_data_manager_unittest.cc
diff --git a/components/autofill/core/browser/personal_data_manager_unittest.cc b/components/autofill/core/browser/personal_data_manager_unittest.cc
index 49bee42bf2c965f858733edeeddcb1a7bca941e0..e33e1710498c4451591ce4e7c0e436d36adaef0b 100644
--- a/components/autofill/core/browser/personal_data_manager_unittest.cc
+++ b/components/autofill/core/browser/personal_data_manager_unittest.cc
@@ -3697,7 +3697,11 @@ TEST_F(PersonalDataManagerTest, GetCreditCardSuggestions_NumberMissing) {
AutofillType(CREDIT_CARD_NUMBER),
/* field_contents= */ base::string16());
ASSERT_EQ(1U, suggestions.size());
- EXPECT_EQ(UTF8ToUTF16("Amex\xC2\xA0\xE2\x8B\xAF"
+ EXPECT_EQ(UTF8ToUTF16("Amex "
+ "\xE2\x80\xA2\xE2\x80\x86"
Mathieu 2016/12/02 21:19:47 what about using base::string16(kMidlineEllipsis)
csashi 2016/12/03 01:02:30 I assumed we intentionally did not want to referen
+ "\xE2\x80\xA2\xE2\x80\x86"
+ "\xE2\x80\xA2\xE2\x80\x86"
+ "\xE2\x80\xA2\xE2\x80\x86"
"8555"),
suggestions[0].value);
EXPECT_EQ(ASCIIToUTF16("04/99"), suggestions[0].label);
@@ -3761,16 +3765,32 @@ TEST_F(PersonalDataManagerTest, GetCreditCardSuggestions_ServerDuplicates) {
suggestions = personal_data_->GetCreditCardSuggestions(
AutofillType(CREDIT_CARD_NUMBER), /* field_contents= */ base::string16());
ASSERT_EQ(4U, suggestions.size());
- EXPECT_EQ(UTF8ToUTF16("Visa\xC2\xA0\xE2\x8B\xAF"
+ EXPECT_EQ(UTF8ToUTF16("Visa "
+ "\xE2\x80\xA2\xE2\x80\x86"
+ "\xE2\x80\xA2\xE2\x80\x86"
+ "\xE2\x80\xA2\xE2\x80\x86"
+ "\xE2\x80\xA2\xE2\x80\x86"
"9012"),
suggestions[0].value);
- EXPECT_EQ(UTF8ToUTF16("Amex\xC2\xA0\xE2\x8B\xAF"
+ EXPECT_EQ(UTF8ToUTF16("Amex "
+ "\xE2\x80\xA2\xE2\x80\x86"
+ "\xE2\x80\xA2\xE2\x80\x86"
+ "\xE2\x80\xA2\xE2\x80\x86"
+ "\xE2\x80\xA2\xE2\x80\x86"
"8555"),
suggestions[1].value);
- EXPECT_EQ(UTF8ToUTF16("MasterCard\xC2\xA0\xE2\x8B\xAF"
+ EXPECT_EQ(UTF8ToUTF16("MasterCard "
+ "\xE2\x80\xA2\xE2\x80\x86"
+ "\xE2\x80\xA2\xE2\x80\x86"
+ "\xE2\x80\xA2\xE2\x80\x86"
+ "\xE2\x80\xA2\xE2\x80\x86"
"2109"),
suggestions[2].value);
- EXPECT_EQ(UTF8ToUTF16("Visa\xC2\xA0\xE2\x8B\xAF"
+ EXPECT_EQ(UTF8ToUTF16("Visa "
+ "\xE2\x80\xA2\xE2\x80\x86"
+ "\xE2\x80\xA2\xE2\x80\x86"
+ "\xE2\x80\xA2\xE2\x80\x86"
+ "\xE2\x80\xA2\xE2\x80\x86"
"2109"),
suggestions[3].value);
}
« no previous file with comments | « components/autofill/core/browser/credit_card_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698