Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2534123002: [counters] Avoid V8_EXPORT_PRIVATE to speed up compilation under windows (Closed)

Created:
4 years ago by Camillo Bruni
Modified:
4 years ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[counters] Avoid V8_EXPORT_PRIVATE to speed up compilation under windows BUG=chromium:668748 Committed: https://crrev.com/95c0ecee66786108a926645d37bba4d8c8a1f258 Cr-Commit-Position: refs/heads/master@{#41351}

Patch Set 1 #

Patch Set 2 : exporting only a subset of RuntimeCallStats #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M src/counters.h View 1 2 chunks +10 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Camillo Bruni
PTAL
4 years ago (2016-11-29 10:13:05 UTC) #4
Michael Achenbach
lgtm
4 years ago (2016-11-29 10:28:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2534123002/20001
4 years ago (2016-11-29 11:55:42 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-29 11:57:22 UTC) #11
commit-bot: I haz the power
4 years ago (2016-11-29 11:57:38 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/95c0ecee66786108a926645d37bba4d8c8a1f258
Cr-Commit-Position: refs/heads/master@{#41351}

Powered by Google App Engine
This is Rietveld 408576698