Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: src/counters.h

Issue 2534123002: [counters] Avoid V8_EXPORT_PRIVATE to speed up compilation under windows (Closed)
Patch Set: exporting only a subset of RuntimeCallStats Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/counters.h
diff --git a/src/counters.h b/src/counters.h
index 4b5ec057bf8192ed06d43b9d5ad87c7e3b986033..da6ed9a3ed98636b2bc5d68092f398375842170a 100644
--- a/src/counters.h
+++ b/src/counters.h
@@ -809,7 +809,7 @@ class RuntimeCallTimer final {
V(StoreIC_StoreTransitionDH) \
V(StoreIC_StoreViaSetter)
-class V8_EXPORT_PRIVATE RuntimeCallStats final : public ZoneObject {
+class RuntimeCallStats final : public ZoneObject {
public:
typedef RuntimeCallCounter RuntimeCallStats::*CounterId;
@@ -838,23 +838,25 @@ class V8_EXPORT_PRIVATE RuntimeCallStats final : public ZoneObject {
// Starting measuring the time for a function. This will establish the
// connection to the parent counter for properly calculating the own times.
- static void Enter(RuntimeCallStats* stats, RuntimeCallTimer* timer,
- CounterId counter_id);
+ V8_EXPORT_PRIVATE static void Enter(RuntimeCallStats* stats,
+ RuntimeCallTimer* timer,
+ CounterId counter_id);
// Leave a scope for a measured runtime function. This will properly add
// the time delta to the current_counter and subtract the delta from its
// parent.
- static void Leave(RuntimeCallStats* stats, RuntimeCallTimer* timer);
+ V8_EXPORT_PRIVATE static void Leave(RuntimeCallStats* stats,
+ RuntimeCallTimer* timer);
// Set counter id for the innermost measurement. It can be used to refine
// event kind when a runtime entry counter is too generic.
- static void CorrectCurrentCounterId(RuntimeCallStats* stats,
- CounterId counter_id);
+ V8_EXPORT_PRIVATE static void CorrectCurrentCounterId(RuntimeCallStats* stats,
+ CounterId counter_id);
- void Reset();
+ V8_EXPORT_PRIVATE void Reset();
// Add all entries from another stats object.
void Add(RuntimeCallStats* other);
- void Print(std::ostream& os);
+ V8_EXPORT_PRIVATE void Print(std::ostream& os);
V8_NOINLINE void Dump(v8::tracing::TracedValue* value);
RuntimeCallStats() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698