Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: components/data_use_measurement/core/data_use_ascriber.cc

Issue 2534023002: Create a DataUseRecorder instance for each page load in Chrome. (Closed)
Patch Set: Use emplace to insert; remove copy constructor Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_use_measurement/core/data_use_ascriber.cc
diff --git a/components/data_use_measurement/core/data_use_ascriber.cc b/components/data_use_measurement/core/data_use_ascriber.cc
index c4dd1e1301587360952d134f8c72a48373723085..2d1c11a068aba6c4b107c7488392c74d45c4ab4f 100644
--- a/components/data_use_measurement/core/data_use_ascriber.cc
+++ b/components/data_use_measurement/core/data_use_ascriber.cc
@@ -22,31 +22,30 @@ std::unique_ptr<net::NetworkDelegate> DataUseAscriber::CreateNetworkDelegate(
}
void DataUseAscriber::OnBeforeUrlRequest(net::URLRequest* request) {
- DataUseRecorder* recorder = GetDataUseRecorder(request);
+ DataUseRecorder* recorder = GetDataUseRecorder(request, true);
if (recorder)
recorder->OnBeforeUrlRequest(request);
}
-void DataUseAscriber::OnBeforeRedirect(net::URLRequest* request,
- const GURL& new_location) {}
-
void DataUseAscriber::OnNetworkBytesSent(net::URLRequest* request,
int64_t bytes_sent) {
- DataUseRecorder* recorder = GetDataUseRecorder(request);
+ DataUseRecorder* recorder = GetDataUseRecorder(request, false);
if (recorder)
recorder->OnNetworkBytesSent(request, bytes_sent);
}
void DataUseAscriber::OnNetworkBytesReceived(net::URLRequest* request,
int64_t bytes_received) {
- DataUseRecorder* recorder = GetDataUseRecorder(request);
+ DataUseRecorder* recorder = GetDataUseRecorder(request, false);
if (recorder)
recorder->OnNetworkBytesReceived(request, bytes_received);
}
+void DataUseAscriber::OnUrlRequestCompleted(net::URLRequest* request,
+ bool started) {}
+
void DataUseAscriber::OnUrlRequestDestroyed(net::URLRequest* request) {
- DataUseRecorder* recorder = GetDataUseRecorder(request);
- // TODO(kundaji): Enforce DCHECK(recorder).
+ DataUseRecorder* recorder = GetDataUseRecorder(request, true);
if (recorder)
recorder->OnUrlRequestDestroyed(request);
}

Powered by Google App Engine
This is Rietveld 408576698