Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1140)

Unified Diff: components/data_use_measurement/core/data_use_ascriber.h

Issue 2534023002: Create a DataUseRecorder instance for each page load in Chrome. (Closed)
Patch Set: Use emplace to insert; remove copy constructor Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_use_measurement/core/data_use_ascriber.h
diff --git a/components/data_use_measurement/core/data_use_ascriber.h b/components/data_use_measurement/core/data_use_ascriber.h
index 58a669cb620c365ff46ca8158a1e2677046d1437..eb591e1cb388968757cd8c4d35b92c002a4ef0d3 100644
--- a/components/data_use_measurement/core/data_use_ascriber.h
+++ b/components/data_use_measurement/core/data_use_ascriber.h
@@ -39,24 +39,22 @@ class DataUseAscriber {
// Returns the DataUseRecorder to which data usage for the given URL should
// be ascribed. If no existing DataUseRecorder exists, a new one will be
- // created.
- virtual DataUseRecorder* GetDataUseRecorder(net::URLRequest* request) = 0;
+ // created only if |can_create_new| is true.
+ virtual DataUseRecorder* GetDataUseRecorder(net::URLRequest* request,
+ bool can_create_new) = 0;
+
+ // Returns a URLRequestClassifier that can classify requests for metrics
+ // recording.
+ virtual std::unique_ptr<URLRequestClassifier> CreateURLRequestClassifier()
+ const = 0;
// Methods called by DataUseNetworkDelegate to propagate data use information:
virtual void OnBeforeUrlRequest(net::URLRequest* request);
-
- virtual void OnBeforeRedirect(net::URLRequest* request,
- const GURL& new_location);
-
virtual void OnNetworkBytesSent(net::URLRequest* request, int64_t bytes_sent);
-
virtual void OnNetworkBytesReceived(net::URLRequest* request,
int64_t bytes_received);
-
+ virtual void OnUrlRequestCompleted(net::URLRequest* request, bool started);
virtual void OnUrlRequestDestroyed(net::URLRequest* request);
-
- virtual std::unique_ptr<URLRequestClassifier> CreateURLRequestClassifier()
- const = 0;
};
} // namespace data_use_measurement
« no previous file with comments | « components/data_use_measurement/core/data_use.cc ('k') | components/data_use_measurement/core/data_use_ascriber.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698