chrome/browser/data_use_measurement/chrome_data_use_ascriber_service.h - Issue 2534023002: Create a DataUseRecorder instance for each page load in Chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/data_use_measurement/chrome_data_use_ascriber_service.h

Issue 2534023002: Create a DataUseRecorder instance for each page load in Chrome. (Closed)

Patch Set: Use emplace to insert; remove copy constructor Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc ('k') | chrome/browser/data_use_measurement/chrome_data_use_ascriber_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/data_use_measurement/chrome_data_use_ascriber_service.h

diff --git a/chrome/browser/data_use_measurement/chrome_data_use_ascriber_service.h b/chrome/browser/data_use_measurement/chrome_data_use_ascriber_service.h

index 1f9ea0ba76f5407624d4a34bdc70417a133982c7..ce7782ea0e5c3f665ee174f97bdfbf229e2313e1 100644

--- a/chrome/browser/data_use_measurement/chrome_data_use_ascriber_service.h

+++ b/chrome/browser/data_use_measurement/chrome_data_use_ascriber_service.h

@@ -53,11 +53,6 @@ class ChromeDataUseAscriberService : public KeyedService {

// methods cannot be called on the IO thread, so the pointer is cast to void*.

void ReadyToCommitNavigation(content::NavigationHandle* navigation_handle);

- // Called when a navigation is redirected. Propagates main frame navigation

- // redirect to the |ascriber_| on the IO thread. NavigationHandle methods

- // cannot be called on the IO thread, so the pointer is cast to void*.

- void DidRedirectNavigation(content::NavigationHandle* navigation_handle);

private:

friend class ChromeDataUseAscriberServiceTest;