Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2988)

Unified Diff: chrome/browser/data_use_measurement/chrome_data_use_ascriber_service.cc

Issue 2534023002: Create a DataUseRecorder instance for each page load in Chrome. (Closed)
Patch Set: Use emplace to insert; remove copy constructor Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/data_use_measurement/chrome_data_use_ascriber_service.cc
diff --git a/chrome/browser/data_use_measurement/chrome_data_use_ascriber_service.cc b/chrome/browser/data_use_measurement/chrome_data_use_ascriber_service.cc
index 069e999c4b955e9b3728daf216be5a481e69262b..d76cb6aa8551e268556a2d0e379c876527b9970e 100644
--- a/chrome/browser/data_use_measurement/chrome_data_use_ascriber_service.cc
+++ b/chrome/browser/data_use_measurement/chrome_data_use_ascriber_service.cc
@@ -115,13 +115,11 @@ void ChromeDataUseAscriberService::RenderFrameDeleted(
void ChromeDataUseAscriberService::DidStartNavigation(
content::NavigationHandle* navigation_handle) {
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
-
if (!navigation_handle->IsInMainFrame())
return;
if (!ascriber_)
return;
-
content::WebContents* web_contents = navigation_handle->GetWebContents();
content::BrowserThread::PostTask(
content::BrowserThread::IO, FROM_HERE,
@@ -155,26 +153,6 @@ void ChromeDataUseAscriberService::ReadyToCommitNavigation(
navigation_handle));
}
-void ChromeDataUseAscriberService::DidRedirectNavigation(
- content::NavigationHandle* navigation_handle) {
- DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
-
- if (!is_initialized_ || !navigation_handle->IsInMainFrame())
- return;
-
- if (!ascriber_)
- return;
-
- content::WebContents* web_contents = navigation_handle->GetWebContents();
- content::BrowserThread::PostTask(
- content::BrowserThread::IO, FROM_HERE,
- base::Bind(&ChromeDataUseAscriber::DidRedirectMainFrameNavigation,
- base::Unretained(ascriber_), navigation_handle->GetURL(),
- web_contents->GetRenderProcessHost()->GetID(),
- web_contents->GetMainFrame()->GetRoutingID(),
- navigation_handle));
-}
-
void ChromeDataUseAscriberService::SetDataUseAscriber(
ChromeDataUseAscriber* ascriber) {
DCHECK(!is_initialized_);

Powered by Google App Engine
This is Rietveld 408576698