Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: components/translate/core/browser/translate_ranker.cc

Issue 2533953003: [translate] Fix enforcement vs logging for TranslateRanker. (Closed)
Patch Set: remove enforcement check Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/translate/core/browser/translate_ranker.cc
diff --git a/components/translate/core/browser/translate_ranker.cc b/components/translate/core/browser/translate_ranker.cc
index 0ebe722719ffbd4761a602406deb847308d69ebf..fe2a214ee397936d1210379f595bfeac9c99b616 100644
--- a/components/translate/core/browser/translate_ranker.cc
+++ b/components/translate/core/browser/translate_ranker.cc
@@ -180,9 +180,7 @@ bool TranslateRanker::ShouldOfferTranslation(
UMA_HISTOGRAM_BOOLEAN("Translate.Ranker.QueryResult", result);
- // If enforcement is enabled, return the real result; otherwise, return the
- // default.
- return IsEnforcementEnabled() ? result : kDefaultResponse;
Roger McFarlane (Chromium) 2016/11/29 18:43:30 The TranslateManager code where this is enforced i
groby1 2016/11/29 19:03:43 The behavior in translate manager is subtly differ
hamelphi 2016/11/29 19:37:06 It is intentional. We want to log the response the
Roger McFarlane (Chromium) 2016/11/29 20:01:00 Precisely. :)
+ return result;
}
TranslateRanker::TranslateRanker() {}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698