[translate] Fix enforcement vs logging for TranslateRanker.

components/translate/core/browser/translate_ranker.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/translate/core/browser/translate_ranker.h"
 
 #include <cmath>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 162 matching lines @@
 
   double score = CalculateScore(accept_ratio, decline_ratio, ignore_ratio,
                                 src_lang, dst_lang, app_locale, country);
 
   DVLOG(2) << "TranslateRanker Score: " << score;
 
   bool result = (score >= kTranslationOfferThreshold);
 
   UMA_HISTOGRAM_BOOLEAN("Translate.Ranker.QueryResult", result);
 
-  // If enforcement is enabled, return the real result; otherwise, return the
-  // default.
-  return IsEnforcementEnabled() ? result : kDefaultResponse;

[Roger McFarlane (Chromium), 2016/11/29 18:43:30]

The TranslateManager code where this is enforced is at
https://cs.chromium.org/chromium/src/components/translate/core/browser/transl...

[groby1, 2016/11/29 19:03:43]

The behavior in translate manager is subtly different, in that the ranker
response is always logged as the actual result, even when enforcement is
disabled. Intentionally, or bug?

[hamelphi, 2016/11/29 19:37:06]

It is intentional. We want to log the response the ranker would have given even
if we don't enforce it. See b/33176772.

[Roger McFarlane (Chromium), 2016/11/29 20:01:00]

Precisely.  :)

+  return result;
 }
 
 TranslateRanker::TranslateRanker() {}
 
 double TranslateRanker::CalculateScore(double accept_ratio,
                                        double decline_ratio,
                                        double ignore_ratio,
                                        const std::string& src_lang,
                                        const std::string& dst_lang,
                                        const std::string& locale,
@@ skipping 105 matching lines @@
   }
 }
 
 void TranslateRanker::RecordTranslateEvent(
     const metrics::TranslateEventProto& translate_event) {
   if (IsLoggingEnabled())
     translate_events_cache_.push_back(translate_event);
 }
 
 }  // namespace translate