Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ConditionalFeatures.cpp

Issue 2533793003: Fix V8 bindings for LongTaskObserver origin trial (Closed)
Patch Set: Add recent attributes to test expectations Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/ConditionalFeatures.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/ConditionalFeatures.cpp b/third_party/WebKit/Source/bindings/core/v8/ConditionalFeatures.cpp
index 1db0c829f80fd89a4039ca1c868477edd0b31b9b..95e4dc3b13cf4621bb414ec65e615d81ae441c4d 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ConditionalFeatures.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ConditionalFeatures.cpp
@@ -20,7 +20,7 @@ void installConditionalFeaturesCore(const WrapperTypeInfo* wrapperTypeInfo,
v8::Local<v8::Object> prototypeObject,
v8::Local<v8::Function> interfaceObject) {
// TODO(iclelland): Generate all of this logic at compile-time, based on the
- // configuration of origin trial enabled attibutes and interfaces in IDL
+ // configuration of origin trial enabled attributes and interfaces in IDL
// files. (crbug.com/615060)
ExecutionContext* executionContext = scriptState->getExecutionContext();
if (!executionContext)
@@ -37,6 +37,14 @@ void installConditionalFeaturesCore(const WrapperTypeInfo* wrapperTypeInfo,
isolate, world, v8::Local<v8::Object>(), prototypeObject,
interfaceObject);
}
+ } else if (wrapperTypeInfo == &V8Window::wrapperTypeInfo) {
+ v8::Local<v8::Object> instanceObject = scriptState->context()->Global();
+ if (RuntimeEnabledFeatures::longTaskObserverEnabled() ||
+ (originTrialContext &&
+ originTrialContext->isTrialEnabled("LongTaskObserver"))) {
+ V8Window::installLongTaskObserver(isolate, world, instanceObject,
+ prototypeObject, interfaceObject);
+ }
}
}
« no previous file with comments | « third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698