[Editing] Add SelectionTemplate::showTreeForThis()

[Editing] Add SelectionTemplate::showTreeForThis()

This CL copies from |VisibleSelection::showTreeForThis()| and renames 
 following "base" and "extend".

TEST=No change in behavior

Review-Url: https://codereview.chromium.org/2533693002
Cr-Commit-Position: refs/heads/master@{#442836}
Committed: https://chromium.googlesource.com/chromium/src/+/449c02654738a3b6a380827a2f730492662faa30

[yoichio, 2016-11-28 07:44:20]

The CQ bit was checked by yoichio@chromium.org to run a CQ dry run

[yoichio, 2016-11-28 07:44:32]

Description was changed from

==========
[Editing] Add SelectionTemplate::showTreeForThis()

TEST=No change in behavior
==========

to

==========
[Editing] Add SelectionTemplate::showTreeForThis()

This CL extracts |static void showTreeForStartAndEnd(const Position&, const
Position)| 
 from |VisibleSelection::showTreeForThis()| and reuses it in  
 SelectionTemplate::showTreeForThis().

TEST=No change in behavior
==========

[yoichio, 2016-11-28 07:44:32]

yoichio@chromium.org changed reviewers:
+ xiaochengh@chromium.org, yosin@chromium.org

[commit-bot: I haz the power, 2016-11-28 07:44:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2016-11-28 07:56:27]

https://codereview.chromium.org/2533693002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/SelectionTemplate.cpp (right):

https://codereview.chromium.org/2533693002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/SelectionTemplate.cpp:110:
VisibleSelectionTemplate<Strategy>::showTreeForStartAndEnd(m_base, m_extent);
We don't want to make |SelectionTemplate| to dependent to |VisibleSelection|.

There are two options:
 - VisibleSelection::showTreeForThis() to call
SelectionTemplate::showTreeForThis()
 - Barand new SelectionTemplate::showTreeForThis(), e.g. "S" and "E" marks
aren't meaningful for |SelectionTemplate| which doesn't have "start" and "end".

[Xiaocheng, 2016-11-28 07:58:34]

How about making SelectionTemplate::showTreeForThis() the major function, since
SelectionTemplate is more fundamental than VS?

Then we can make VS::showTreeForThis a wrapper of
SelectionTemplate::showTreeForThis as follows:

VS::showTreeForThis() {
  asSelection().showTreeForThis();
}

[commit-bot: I haz the power, 2016-11-28 08:59:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 08:59:11]

Dry run: This issue passed the CQ dry run.

[yoichio, 2016-11-29 09:34:16]

The CQ bit was checked by yoichio@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 09:34:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 12:45:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 12:45:54]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[yoichio, 2016-11-30 02:10:12]

Description was changed from

==========
[Editing] Add SelectionTemplate::showTreeForThis()

This CL extracts |static void showTreeForStartAndEnd(const Position&, const
Position)| 
 from |VisibleSelection::showTreeForThis()| and reuses it in  
 SelectionTemplate::showTreeForThis().

TEST=No change in behavior
==========

to

==========
[Editing] Add SelectionTemplate::showTreeForThis()

This CL copies from |VisibleSelection::showTreeForThis()| and renames 
 following "base" and "extend".

TEST=No change in behavior
==========

[yoichio, 2016-11-30 02:10:55]

Make another SelectionTemplate::showTreeForThis() and let VisblePosion's as is.

[Xiaocheng, 2016-11-30 02:24:17]

lgtm

[yosin_UTC9, 2016-11-30 02:34:31]

https://codereview.chromium.org/2533693002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/SelectionTemplate.cpp (right):

https://codereview.chromium.org/2533693002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/SelectionTemplate.cpp:7: #include
"core/editing/VisibleSelection.h"
We should not include "VisibleSelection.h" in SelectionTemplate.cpp

[yoichio, 2016-11-30 04:45:41]

https://codereview.chromium.org/2533693002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/SelectionTemplate.cpp (right):

https://codereview.chromium.org/2533693002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/SelectionTemplate.cpp:7: #include
"core/editing/VisibleSelection.h"
On 2016/11/30 02:34:31, Yosi_UTC9 wrote:
> We should not include "VisibleSelection.h" in SelectionTemplate.cpp

Done.

[yoichio, 2016-11-30 04:45:54]

The CQ bit was checked by yoichio@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-30 04:46:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 06:48:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 06:48:14]

Dry run: Try jobs failed on following builders:
  blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[yoichio, 2016-12-02 01:53:46]

PTAL

[yoichio, 2017-01-11 05:27:49]

PTAL

[yosin_UTC9, 2017-01-11 06:01:55]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2017-01-11 06:01:55]

lgtm

[yosin_UTC9, 2017-01-11 06:01:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
xiaochengh@chromium.org
Link to the patchset: https://codereview.chromium.org/2533693002/#ps40001
(title: "update")

[commit-bot: I haz the power, 2017-01-11 06:02:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 10:07:37]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484114515573480,
"parent_rev": "2ea32a808df771b5c5acb53a3819010cf054e021", "commit_rev":
"449c02654738a3b6a380827a2f730492662faa30"}

[commit-bot: I haz the power, 2017-01-11 10:08:06]

Description was changed from

==========
[Editing] Add SelectionTemplate::showTreeForThis()

This CL copies from |VisibleSelection::showTreeForThis()| and renames 
 following "base" and "extend".

TEST=No change in behavior
==========

to

==========
[Editing] Add SelectionTemplate::showTreeForThis()

This CL copies from |VisibleSelection::showTreeForThis()| and renames 
 following "base" and "extend".

TEST=No change in behavior

Review-Url: https://codereview.chromium.org/2533693002
Cr-Commit-Position: refs/heads/master@{#442836}
Committed:
https://chromium.googlesource.com/chromium/src/+/449c02654738a3b6a380827a2f73...
==========

[commit-bot: I haz the power, 2017-01-11 10:08:07]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/449c02654738a3b6a380827a2f73...