Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Unified Diff: third_party/WebKit/Source/core/css/properties/CSSPropertyDescriptor.h

Issue 2533673002: Added CSSPropertyAPI and CSS padding properties which implement this API (Closed)
Patch Set: review comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/properties/CSSPropertyDescriptor.h
diff --git a/third_party/WebKit/Source/core/css/properties/CSSPropertyDescriptor.h b/third_party/WebKit/Source/core/css/properties/CSSPropertyDescriptor.h
new file mode 100644
index 0000000000000000000000000000000000000000..abf329baadc3aa7ddb44cbb5c911c826b4c0660f
--- /dev/null
+++ b/third_party/WebKit/Source/core/css/properties/CSSPropertyDescriptor.h
@@ -0,0 +1,29 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "core/CSSPropertyNames.h"
+#include "core/css/properties/CSSPropertyAPI.h"
sashab 2016/11/30 23:48:39 Not needed yayyyyy
aazzam 2016/12/01 04:17:54 done
+
+namespace blink {
+
+class CSSValue;
+
+// This struct should contain function pointers matching those declared in
alancutter (OOO until 2018) 2016/11/30 23:46:54 s/This struct should contain/contains/
aazzam 2016/12/01 04:17:54 done
+// CSSPropertyAPI. API functions should also be added to the getDescriptor
+// template below.
alancutter (OOO until 2018) 2016/11/30 23:46:54 This sentence is out of date.
aazzam 2016/12/01 04:17:54 done
+struct CSSPropertyDescriptor {
+ const CSSValue* (*parseSingleValue)(CSSParserTokenRange&,
sashab 2016/11/30 23:48:39 // These methods match the declarations in rnefn f
aazzam 2016/12/01 04:17:54 I think i already am saying this in the comment ab
+ const CSSParserContext&);
+ CSSPropertyID id;
+
+ // This is used to check if the descriptor is valid and is for internal use
+ // only.
+ bool isValid;
alancutter (OOO until 2018) 2016/11/30 23:46:54 What "internal" means is very unclear here. Use pr
+
+ // This is placed in CSSPropertyDescriptor since it is used outside this file
+ // in the parser
alancutter (OOO until 2018) 2016/11/30 23:46:54 This is implicit in being a public method, no need
sashab 2016/11/30 23:48:39 full stop You can call this function to get the d
aazzam 2016/12/01 04:17:54 ^ see alan's comment
+ static const CSSPropertyDescriptor& get(CSSPropertyID);
+};
+
+} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698