Added CSSPropertyAPI and CSS padding properties which implement this API

third_party/WebKit/Source/core/css/properties/CSSPropertyDescriptor.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "core/CSSPropertyNames.h"
+#include "core/css/properties/CSSPropertyAPI.h"

[sashab, 2016/11/30 23:48:39]

Not needed yayyyyy

[aazzam, 2016/12/01 04:17:54]

done

+
+namespace blink {
+
+class CSSValue;
+
+// This struct should contain function pointers matching those declared in

[alancutter (OOO until 2018), 2016/11/30 23:46:54]

s/This struct should contain/contains/

[aazzam, 2016/12/01 04:17:54]

done

+// CSSPropertyAPI. API functions should also be added to the getDescriptor
+// template below.

[alancutter (OOO until 2018), 2016/11/30 23:46:54]

This sentence is out of date.

[aazzam, 2016/12/01 04:17:54]

done

+struct CSSPropertyDescriptor {
+  const CSSValue* (*parseSingleValue)(CSSParserTokenRange&,

[sashab, 2016/11/30 23:48:39]

// These methods match the declarations in rnefn file

[aazzam, 2016/12/01 04:17:54]

I think i already am saying this in the comment above?

+                                      const CSSParserContext&);
+  CSSPropertyID id;
+
+  // This is used to check if the descriptor is valid and is for internal use
+  // only.
+  bool isValid;

[alancutter (OOO until 2018), 2016/11/30 23:46:54]

What "internal" means is very unclear here. Use private and friend keywords to
make access restrictions explicit.

+
+  // This is placed in CSSPropertyDescriptor since it is used outside this file
+  // in the parser

[alancutter (OOO until 2018), 2016/11/30 23:46:54]

This is implicit in being a public method, no need for this comment.

[sashab, 2016/11/30 23:48:39]

full stop

You can call this function to get the descriptor for a property, and then call
methods....
also not parser specific :)

[aazzam, 2016/12/01 04:17:54]

^ see alan's comment

+  static const CSSPropertyDescriptor& get(CSSPropertyID);
+};
+
+}  // namespace blink