Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2533613002:
Correct iOS hermetic plist rule. (Closed)
|
Created:
4 years ago by justincohen Modified:
4 years ago CC:
chromium-reviews, mac-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionCorrect iOS hermetic plist rule.
BUG=632229
Committed: https://crrev.com/c49104d2d37cd6ad1c876ba8865b976f91a0ed98
Cr-Commit-Position: refs/heads/master@{#435135}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Move developer_dir to front of args list #Patch Set 3 : nit #Messages
Total messages: 25 (11 generated)
justincohen@chromium.org changed reviewers: + erikchen@chromium.org, sdefresne@chromium.org
ptal
lgtm
https://codereview.chromium.org/2533613002/diff/1/build/config/mac/base_rules... File build/config/mac/base_rules.gni (right): https://codereview.chromium.org/2533613002/diff/1/build/config/mac/base_rules... build/config/mac/base_rules.gni:56: if (!use_system_xcode) { Will this be parsed as an unknown argument if it isn't the first argument?
https://codereview.chromium.org/2533613002/diff/1/build/config/mac/base_rules... File build/config/mac/base_rules.gni (right): https://codereview.chromium.org/2533613002/diff/1/build/config/mac/base_rules... build/config/mac/base_rules.gni:56: if (!use_system_xcode) { On 2016/11/28 15:57:10, erikchen wrote: > Will this be parsed as an unknown argument if it isn't the first argument? It seems to work here? I can move it to the front if you want.
On 2016/11/28 19:42:02, justincohen wrote: > https://codereview.chromium.org/2533613002/diff/1/build/config/mac/base_rules... > File build/config/mac/base_rules.gni (right): > > https://codereview.chromium.org/2533613002/diff/1/build/config/mac/base_rules... > build/config/mac/base_rules.gni:56: if (!use_system_xcode) { > On 2016/11/28 15:57:10, erikchen wrote: > > Will this be parsed as an unknown argument if it isn't the first argument? > > It seems to work here? I can move it to the front if you want. I'd prefer that, thanks. lgtm
The CQ bit was checked by justincohen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from erikchen@chromium.org, sdefresne@chromium.org Link to the patchset: https://codereview.chromium.org/2533613002/#ps40001 (title: "nit")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by justincohen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by justincohen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by justincohen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480482867560310,
"parent_rev": "341c2f501b952ce4259ad15f624cbc9ad7fd97da", "commit_rev":
"6d30d138d5a7982b39c5d0e0edacc8adeddb8027"}
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Correct iOS hermetic plist rule. BUG=632229 ========== to ========== Correct iOS hermetic plist rule. BUG=632229 Committed: https://crrev.com/c49104d2d37cd6ad1c876ba8865b976f91a0ed98 Cr-Commit-Position: refs/heads/master@{#435135} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/c49104d2d37cd6ad1c876ba8865b976f91a0ed98 Cr-Commit-Position: refs/heads/master@{#435135} |
