Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Side by Side Diff: build/config/mac/base_rules.gni

Issue 2533613002: Correct iOS hermetic plist rule. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # This file contains rules that are shared between Mac and iOS. 5 # This file contains rules that are shared between Mac and iOS.
6 6
7 import("//build/toolchain/toolchain.gni") 7 import("//build/toolchain/toolchain.gni")
8 import("//build/config/mac/symbols.gni") 8 import("//build/config/mac/symbols.gni")
9 9
10 if (is_mac) { 10 if (is_mac) {
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 invoker.output, 46 invoker.output,
47 ] 47 ]
48 args = [ 48 args = [
49 "plutil", 49 "plutil",
50 "-convert", 50 "-convert",
51 invoker.format, 51 invoker.format,
52 "-o", 52 "-o",
53 rebase_path(invoker.output, root_build_dir), 53 rebase_path(invoker.output, root_build_dir),
54 rebase_path(invoker.source, root_build_dir), 54 rebase_path(invoker.source, root_build_dir),
55 ] 55 ]
56 if (!use_system_xcode) {
erikchen 2016/11/28 15:57:10 Will this be parsed as an unknown argument if it i
justincohen 2016/11/28 19:42:02 It seems to work here? I can move it to the front
57 args += [
58 "--developer_dir",
59 hermetic_xcode_path,
60 ]
61 }
56 } 62 }
57 } 63 }
58 64
59 # Template to merge multiple plist files and perform variable substitutions. 65 # Template to merge multiple plist files and perform variable substitutions.
60 # 66 #
61 # Arguments 67 # Arguments
62 # 68 #
63 # plist_templates: 69 # plist_templates:
64 # string array, paths to plist files which will be used for the bundle. 70 # string array, paths to plist files which will be used for the bundle.
65 # 71 #
(...skipping 166 matching lines...) Expand 10 before | Expand all | Expand 10 after
232 ] 238 ]
233 if (!use_system_xcode) { 239 if (!use_system_xcode) {
234 args += [ 240 args += [
235 "--developer_dir", 241 "--developer_dir",
236 hermetic_xcode_path, 242 hermetic_xcode_path,
237 ] 243 ]
238 } 244 }
239 args += ibtool_flags 245 args += ibtool_flags
240 } 246 }
241 } 247 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698