Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 2533463002: Fix 'combo breaker' in CreateDynamicFunction to handle template literals. (Closed)

Created:
4 years ago by vogelheim
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix 'combo breaker' in CreateDynamicFunction to handle template literals. BUG=chromium:663410 Committed: https://crrev.com/e0d608a2b1dcdd8a02c3d3db691bafec8461815a Cr-Commit-Position: refs/heads/master@{#41320}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M src/builtins/builtins-function.cc View 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/regress-crbug-663410.js View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
vogelheim
ptal (See bug for more info.)
4 years ago (2016-11-28 13:17:02 UTC) #6
jochen (gone - plz use gerrit)
lgtm
4 years ago (2016-11-28 13:18:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2533463002/1
4 years ago (2016-11-28 13:55:33 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-28 14:43:45 UTC) #11
commit-bot: I haz the power
4 years ago (2016-11-28 14:44:26 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e0d608a2b1dcdd8a02c3d3db691bafec8461815a
Cr-Commit-Position: refs/heads/master@{#41320}

Powered by Google App Engine
This is Rietveld 408576698