Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: src/builtins/builtins-function.cc

Issue 2533463002: Fix 'combo breaker' in CreateDynamicFunction to handle template literals. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/regress-crbug-663410.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/builtins/builtins-function.cc
diff --git a/src/builtins/builtins-function.cc b/src/builtins/builtins-function.cc
index 3672794527bbd85a1f7914818aed123c25da544c..6cd1b283ec6f1e144bc1fe8cff3b5a5783da185c 100644
--- a/src/builtins/builtins-function.cc
+++ b/src/builtins/builtins-function.cc
@@ -61,7 +61,7 @@ MaybeHandle<Object> CreateDynamicFunction(Isolate* isolate,
// If the formal parameters include an unbalanced block comment, the
// function must be rejected. Since JavaScript does not allow nested
// comments we can include a trailing block comment to catch this.
- builder.AppendCString("\n/**/");
+ builder.AppendCString("\n/*``*/");
}
builder.AppendCString(") {\n");
if (argc > 0) {
« no previous file with comments | « no previous file | test/mjsunit/regress-crbug-663410.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698