Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 2533443004: [NTP Snippets] Bookmark suggestions: remove creation_date_fallback (Closed)

Created:
4 years ago by Marc Treib
Modified:
4 years ago
Reviewers:
jkrcal
CC:
chromium-reviews, ntp-dev+reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP Snippets] Bookmark suggestions: remove creation_date_fallback BUG=653826 Committed: https://crrev.com/19204b91deb7bec1c735a77c55d4c70fbd8dfcbd Cr-Commit-Position: refs/heads/master@{#434636}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -194 lines) Patch
M components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h View 2 chunks +2 lines, -9 lines 0 comments Download
M components/ntp_snippets/bookmarks/bookmark_last_visit_utils.cc View 6 chunks +16 lines, -62 lines 0 comments Download
M components/ntp_snippets/bookmarks/bookmark_last_visit_utils_unittest.cc View 5 chunks +5 lines, -58 lines 0 comments Download
M components/ntp_snippets/bookmarks/bookmark_suggestions_provider.h View 1 chunk +0 lines, -5 lines 0 comments Download
M components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc View 10 chunks +18 lines, -54 lines 0 comments Download
M components/ntp_snippets/pref_names.h View 1 chunk +0 lines, -3 lines 0 comments Download
M components/ntp_snippets/pref_names.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Marc Treib
PTAL!
4 years ago (2016-11-25 16:22:40 UTC) #2
jkrcal
On 2016/11/25 16:22:40, Marc Treib wrote: > PTAL! lgtm, thanks! (feel free to land first, ...
4 years ago (2016-11-28 10:54:30 UTC) #3
Marc Treib
On 2016/11/28 10:54:30, jkrcal wrote: > On 2016/11/25 16:22:40, Marc Treib wrote: > > PTAL! ...
4 years ago (2016-11-28 10:58:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2533443004/1
4 years ago (2016-11-28 11:46:35 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-28 11:50:37 UTC) #12
commit-bot: I haz the power
4 years ago (2016-11-28 11:52:55 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/19204b91deb7bec1c735a77c55d4c70fbd8dfcbd
Cr-Commit-Position: refs/heads/master@{#434636}

Powered by Google App Engine
This is Rietveld 408576698