Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h

Issue 2533443004: [NTP Snippets] Bookmark suggestions: remove creation_date_fallback (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/ntp_snippets/bookmarks/bookmark_last_visit_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h
diff --git a/components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h b/components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h
index 7b59832397ff0a1515aa7d5bd5871779a7dea01f..cdd5cb6957ae85c6268cc4e5e91c6f967afb458a 100644
--- a/components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h
+++ b/components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h
@@ -34,12 +34,8 @@ void UpdateBookmarkOnURLVisitedInMainFrame(
// which also includes the case that the bookmark was dismissed from the NTP.
// As visits, we primarily understand visits on Android (the visit when the
// bookmark is created also counts). Visits on desktop platforms are considered
-// only if |consider_visits_from_desktop|. If no info about last visit date is
-// present and |creation_date_fallback| is true, the date when the bookmarks is
-// created is used as the alst visit date (most likely, it is the date when the
-// bookmark was synced to this device).
+// only if |consider_visits_from_desktop|.
bool GetLastVisitDateForNTPBookmark(const bookmarks::BookmarkNode* node,
- bool creation_date_fallback,
bool consider_visits_from_desktop,
base::Time* out);
@@ -57,17 +53,14 @@ void MarkAllBookmarksUndismissed(bookmarks::BookmarkModel* bookmark_model);
// For each bookmarked URL, it returns the most recently created bookmark.
// The result is ordered by visit time (the most recent first). Only bookmarks
// visited after |min_visit_time| are considered, at most |max_count| bookmarks
-// are returned. If this results into less than |min_count| bookmarks, the list
-// is filled up with older bookmarks sorted by their last visit / creation date.
+// are returned.
// If |consider_visits_from_desktop|, also visits to bookmarks on synced desktop
// platforms are considered (and not only on this and other synced Android
// devices).
std::vector<const bookmarks::BookmarkNode*> GetRecentlyVisitedBookmarks(
bookmarks::BookmarkModel* bookmark_model,
- int min_count,
int max_count,
const base::Time& min_visit_time,
- bool creation_date_fallback,
bool consider_visits_from_desktop);
// Returns the list of all dismissed bookmarks. Only used for debugging.
« no previous file with comments | « no previous file | components/ntp_snippets/bookmarks/bookmark_last_visit_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698