Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issue 2533413002: cros: Small JS cleanup in lock screen code. (Closed)

Created:
4 years ago by jdufault
Modified:
4 years ago
Reviewers:
Alexander Alekseev
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: Small JS cleanup in lock screen code. BUG=669638 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/0de81e6e69550022ed7bfd0ade6d56634890e676 Cr-Commit-Position: refs/heads/master@{#435783}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -13 lines) Patch
M chrome/browser/resources/chromeos/login/lock.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/login/account_picker/user_pod_row.js View 2 chunks +2 lines, -11 lines 0 comments Download
M ui/login/display_manager.js View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (12 generated)
jdufault
alemate@ PTAL. There should be no functional change.
4 years ago (2016-12-01 18:55:21 UTC) #9
Alexander Alekseev
lgtm
4 years ago (2016-12-01 23:08:07 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2533413002/1
4 years ago (2016-12-01 23:08:38 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-02 00:11:28 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-02 00:13:16 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0de81e6e69550022ed7bfd0ade6d56634890e676
Cr-Commit-Position: refs/heads/master@{#435783}

Powered by Google App Engine
This is Rietveld 408576698