Introduce a separate FunctionLiteral ID for Eval

Introduce a separate FunctionLiteral ID for Eval

Top level SharedFunctionInfos will end up in a scripts SFI list, but
eval'd SFIs shouldn't. Separate IDs will allow for adding a
corresponding DCHECK.

BUG=v8:5589
R=marja@chromium.org

Committed: https://crrev.com/c6d421ff9aee7f3cab9e48faac88f6b08d2f1cf5
Cr-Commit-Position: refs/heads/master@{#41421}

[jochen (gone - plz use gerrit), 2016-12-01 10:37:20]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 10:37:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 11:07:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 11:07:19]

Dry run: This issue passed the CQ dry run.

[marja, 2016-12-01 11:59:21]

lgtm

[jochen (gone - plz use gerrit), 2016-12-01 12:01:17]

The CQ bit was checked by jochen@chromium.org

[commit-bot: I haz the power, 2016-12-01 12:01:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 12:02:49]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1480593677741940, "parent_rev":
"f1dfac85f67507993c60b774960b9c577fe281c6", "commit_rev":
"147f2f02a083fe1a192ac5270a71ec68742adc40"}

[commit-bot: I haz the power, 2016-12-01 12:02:55]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-01 12:03:28]

Description was changed from

==========
Introduce a separate FunctionLiteral ID for Eval

Top level SharedFunctionInfos will end up in a scripts SFI list, but
eval'd SFIs shouldn't. Separate IDs will allow for adding a
corresponding DCHECK.

BUG=v8:5589
R=marja@chromium.org
==========

to

==========
Introduce a separate FunctionLiteral ID for Eval

Top level SharedFunctionInfos will end up in a scripts SFI list, but
eval'd SFIs shouldn't. Separate IDs will allow for adding a
corresponding DCHECK.

BUG=v8:5589
R=marja@chromium.org

Committed: https://crrev.com/c6d421ff9aee7f3cab9e48faac88f6b08d2f1cf5
Cr-Commit-Position: refs/heads/master@{#41421}
==========

[commit-bot: I haz the power, 2016-12-01 12:03:29]

Patchset 1 (id:??) landed as
https://crrev.com/c6d421ff9aee7f3cab9e48faac88f6b08d2f1cf5
Cr-Commit-Position: refs/heads/master@{#41421}

[jochen (gone - plz use gerrit), 2016-12-02 10:01:16]

turns out that this breaks, as eval() functions have their own Script object,
and the top-level FunctionLiteral should be stored in slot 0 of that special
script

[jochen (gone - plz use gerrit), 2016-12-02 10:01:53]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2544003003/ by jochen@chromium.org.

The reason for reverting is: My assumption that eval and top-level code should
be handled differently was wrong.