Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: src/ast/ast.h

Issue 2533303006: Introduce a separate FunctionLiteral ID for Eval (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/parsing/parser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ast/ast.h
diff --git a/src/ast/ast.h b/src/ast/ast.h
index 7dcd535c65aab1b425f1be837f6488820ff1232b..52a77093777c54ad5329d491ac1de7b0a6903c9e 100644
--- a/src/ast/ast.h
+++ b/src/ast/ast.h
@@ -2550,7 +2550,7 @@ class FunctionLiteral final : public Expression {
kAccessorOrMethod
};
- enum IdType { kIdTypeInvalid = -1, kIdTypeTopLevel = 0 };
+ enum IdType { kIdTypeEval = -2, kIdTypeInvalid = -1, kIdTypeTopLevel = 0 };
enum ParameterFlag { kNoDuplicateParameters, kHasDuplicateParameters };
@@ -3452,14 +3452,14 @@ class AstNodeFactory final BASE_EMBEDDED {
FunctionLiteral* NewScriptOrEvalFunctionLiteral(
DeclarationScope* scope, ZoneList<Statement*>* body,
int materialized_literal_count, int expected_property_count,
- int parameter_count) {
+ int parameter_count, int function_literal_id) {
return new (zone_) FunctionLiteral(
zone_, ast_value_factory_->empty_string(), ast_value_factory_, scope,
body, materialized_literal_count, expected_property_count,
parameter_count, parameter_count, FunctionLiteral::kAnonymousExpression,
FunctionLiteral::kNoDuplicateParameters,
FunctionLiteral::kShouldLazyCompile, 0, false, true,
- FunctionLiteral::kIdTypeTopLevel);
+ function_literal_id);
}
ClassLiteral::Property* NewClassLiteralProperty(
« no previous file with comments | « no previous file | src/parsing/parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698