Add Windows 10 build number to user-agent

Add Windows 10 build number to user-agent

The build number would be added to the version string in UA
only if the major version of Windows is equal or greater than 10.
Nothing would be changed for the old version of Windows.

BUG=664622
Committed: https://crrev.com/bb034491431fa28ce9b2be66b17c0417dffebc13
Cr-Commit-Position: refs/heads/master@{#437532}

[Sunny, 2016-11-29 19:08:36]

Description was changed from

==========
Add Windows 10 build number to user-agent

The build number would be added to the version string in UA
only if the major version of Windows is equal or greater than 10.
Nothing would be changed for the old version of Windows.

BUG=664622
==========

to

==========
Add Windows 10 build number to user-agent

The build number would be added to the version string in UA
only if the major version of Windows is equal or greater than 10.
Nothing would be changed for the old version of Windows.

BUG=664622
==========

[Sunny, 2016-11-29 19:08:37]

ratsunny@gmail.com changed reviewers:
+ dcheng@chromium.org, jln@chromium.org

[Sunny, 2016-11-30 02:40:47]

The CQ bit was checked by ratsunny@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-30 02:41:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 02:41:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 02:41:52]

Dry run: No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[dcheng, 2016-12-05 18:59:02]

dcheng@chromium.org changed reviewers:
+ jochen@chromium.org
- jln@chromium.org

[dcheng, 2016-12-05 18:59:02]

Replacing jln with jochen@ as content reviewer.

the base bits seem reasonable, but I'm wondering if we should simplify this so
we just always return 0 as the bugfix number if the OS version < 10. That would
simplify the //content, but I suppose it might break compat (e.g. 6.1.0 would be
weird, right)?

[Sunny, 2016-12-06 03:37:55]

On 2016/12/05 18:59:02, dcheng wrote:
> Replacing jln with jochen@ as content reviewer.
> 
> the base bits seem reasonable, but I'm wondering if we should simplify this so
> we just always return 0 as the bugfix number if the OS version < 10. That
would
> simplify the //content, but I suppose it might break compat (e.g. 6.1.0 would
be
> weird, right)?

Yes, I believe version number like "6.1.0" in user agent seems wired and maybe a
not necessary change.
I also wonder if change bugfix_version to windows build number may crash some
other things relies on bugfix_version=0 on windows, but after a quick search it
seems safe to change it. Could you have a look?

[jochen (gone - plz use gerrit), 2016-12-06 09:07:30]

jochen@chromium.org changed reviewers:
+ pkasting@chromium.org

[jochen (gone - plz use gerrit), 2016-12-06 09:07:32]

Adding Peter who (iirc) worked on the UA string before

[Rick Byers, 2016-12-06 16:19:17]

On 2016/12/06 03:37:55, Sunny wrote:
> On 2016/12/05 18:59:02, dcheng wrote:
> > Replacing jln with jochen@ as content reviewer.
> > 
> > the base bits seem reasonable, but I'm wondering if we should simplify this
so
> > we just always return 0 as the bugfix number if the OS version < 10. That
> would
> > simplify the //content, but I suppose it might break compat (e.g. 6.1.0
would
> be
> > weird, right)?
> 
> Yes, I believe version number like "6.1.0" in user agent seems wired and maybe
a
> not necessary change.
> I also wonder if change bugfix_version to windows build number may crash some
> other things relies on bugfix_version=0 on windows, but after a quick search
it
> seems safe to change it. Could you have a look?

IMHO if it's easy to preserve the existing behavior for pre-Win10 then we should
do that.  The only ask from Microsoft here is that we expose the bugfix
component on Win10 since that is effectively now the same as the old "minor"
version number.

[Rick Byers, 2016-12-06 16:40:56]

rbyers@chromium.org changed reviewers:
+ rbyers@chromium.org

[Rick Byers, 2016-12-06 16:40:57]

LGTM for web platform (but I'm not a content/base owner so still needs an OWNER
stamp).  See my argument at
https://bugs.chromium.org/p/chromium/issues/detail?id=664622#c7 for why we
should just land this.

[dcheng, 2016-12-07 03:18:34]

On 2016/12/06 16:40:57, Rick Byers wrote:
> LGTM for web platform (but I'm not a content/base owner so still needs an
OWNER
> stamp).  See my argument at
> https://bugs.chromium.org/p/chromium/issues/detail?id=664622#c7 for why we
> should just land this.

OK, my only concern here was that there's code that relies on bugfix number
being 0, but it looks like that doesn't exist (from what I can tell from
codesearch). LGTM.

[Sunny, 2016-12-08 09:51:18]

Hi everyone, I'd like to know whether I can flip commit bit now or need wait
more LGTM from other reviewers, thanks~

[jochen (gone - plz use gerrit), 2016-12-08 12:06:10]

lgtm

[jochen (gone - plz use gerrit), 2016-12-08 12:07:11]

"git cl presubmit" should tell you whether you're good to land in general

[Sunny, 2016-12-08 15:40:24]

The CQ bit was checked by ratsunny@gmail.com

[commit-bot: I haz the power, 2016-12-08 15:40:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 17:02:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 17:02:51]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Sunny, 2016-12-09 09:45:45]

Hi everyone

I'm so confused that a windows only change cause android test crash, any ideas?

Thanks

[Sunny, 2016-12-09 14:25:57]

The CQ bit was checked by ratsunny@gmail.com

[commit-bot: I haz the power, 2016-12-09 14:26:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 14:30:10]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481293557501290, "parent_rev":
"4a641f8aadf16447fe497da2f7cfb0301b594d97", "commit_rev":
"d8bb6a2e090f11716943e914deebfd2bb7ad0d9a"}

[commit-bot: I haz the power, 2016-12-09 14:30:35]

Description was changed from

==========
Add Windows 10 build number to user-agent

The build number would be added to the version string in UA
only if the major version of Windows is equal or greater than 10.
Nothing would be changed for the old version of Windows.

BUG=664622
==========

to

==========
Add Windows 10 build number to user-agent

The build number would be added to the version string in UA
only if the major version of Windows is equal or greater than 10.
Nothing would be changed for the old version of Windows.

BUG=664622

Review-Url: https://codereview.chromium.org/2533303003
==========

[commit-bot: I haz the power, 2016-12-09 14:30:38]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-09 14:33:04]

Description was changed from

==========
Add Windows 10 build number to user-agent

The build number would be added to the version string in UA
only if the major version of Windows is equal or greater than 10.
Nothing would be changed for the old version of Windows.

BUG=664622

Review-Url: https://codereview.chromium.org/2533303003
==========

to

==========
Add Windows 10 build number to user-agent

The build number would be added to the version string in UA
only if the major version of Windows is equal or greater than 10.
Nothing would be changed for the old version of Windows.

BUG=664622

Committed: https://crrev.com/bb034491431fa28ce9b2be66b17c0417dffebc13
Cr-Commit-Position: refs/heads/master@{#437532}
==========

[commit-bot: I haz the power, 2016-12-09 14:33:05]

Patchset 1 (id:??) landed as
https://crrev.com/bb034491431fa28ce9b2be66b17c0417dffebc13
Cr-Commit-Position: refs/heads/master@{#437532}

[robliao, 2016-12-15 23:56:21]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2581033002/ by robliao@chromium.org.

The reason for reverting is: This can cause services expecting a Windows
user-agent of only two version tokens (10.0) to break..

[Rick Byers, 2016-12-21 01:39:53]

On 2016/12/09 09:45:45, Sunny wrote:
> Hi everyone
> 
> I'm so confused that a windows only change cause android test crash, any
ideas?
> 
> Thanks

Sorry I didn't see this sooner: Don't worry, that was almost certainly test
flakiness.

On 2016/12/15 23:56:21, robliao - OOO 12-21 to 1-2017 wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/2581033002/ by mailto:robliao@chromium.org.
> 
> The reason for reverting is: This can cause services expecting a Windows
> user-agent of only two version tokens (10.0) to break..

Google maps has landed a fix for this, but we've talked with the Microsoft folks
that wanted us to make this change and they'd like to do some more compat
testing to help ensure they haven't missed other site compat issues.  Let's hold
off on relanding this for a bit (perhaps until the corresponding Edge change has
actually made it to broad deployment early 2017).  Thanks for contributing the
patch though - it'll be easy to reland when the time is right!