Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1199)

Issue 2533273002: media: Cleanup class/struct forward declarations (Closed)

Created:
4 years ago by jbriance
Modified:
4 years ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, posciak+watch_chromium.org, yzshen+watch_chromium.org, apacible+watch_chromium.org, alokp+watch_chromium.org, mlamouri+watch-media_chromium.org, miu+watch_chromium.org, cbentzel+watch_chromium.org, toyoshim+midi_chromium.org, chromoting-reviews_chromium.org, jam, abarth-chromium, eme-reviews_chromium.org, darin-cc_chromium.org, xjz+watch_chromium.org, imcheng+watch_chromium.org, jasonroberts+watch_google.com, feature-media-reviews_chromium.org, mcasas+watch+vc_chromium.org, piman+watch_chromium.org, avayvod+watch_chromium.org, Aaron Boodman, mac-reviews_chromium.org, darin (slow to review), isheriff+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Cleanup class/struct forward declarations Remove useless class and struct forward declarations, and add missing ones in media header files. BUG=662195 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/752a7f6980603342771f7e89c7e6717fb59c8954 Cr-Commit-Position: refs/heads/master@{#435198}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase + address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -107 lines) Patch
M content/browser/media/capture/web_contents_audio_input_stream_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/audio/clockless_audio_sink.h View 1 chunk +0 lines, -5 lines 0 comments Download
M media/audio/fake_audio_input_stream.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/audio/fake_audio_worker.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/audio/mac/audio_low_latency_input_mac.h View 1 chunk +0 lines, -2 lines 0 comments Download
M media/audio/pulse/pulse_output.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/audio/sounds/audio_stream_handler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M media/audio/virtual_audio_input_stream.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/audio/virtual_audio_sink.h View 1 chunk +0 lines, -4 lines 0 comments Download
M media/base/android/media_drm_bridge.h View 1 chunk +0 lines, -2 lines 0 comments Download
M media/base/audio_decoder.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/base/media.h View 1 chunk +0 lines, -4 lines 0 comments Download
M media/base/pipeline.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/base/pipeline_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/base/renderer.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/blink/texttrack_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/blink/webcontentdecryptionmodule_impl.h View 1 2 chunks +0 lines, -5 lines 0 comments Download
M media/blink/webencryptedmediaclient_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/blink/webmediaplayer_cast_android.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/blink/webmediaplayer_impl.h View 2 chunks +0 lines, -2 lines 0 comments Download
M media/blink/webmediaplayer_params.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/cast/cast_sender.h View 1 chunk +0 lines, -2 lines 0 comments Download
M media/cast/cast_sender_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/cast/net/cast_transport.h View 1 chunk +0 lines, -5 lines 0 comments Download
M media/cast/net/rtp/rtp_packetizer.h View 1 chunk +0 lines, -4 lines 0 comments Download
M media/cast/test/utility/in_process_receiver.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/cdm/ppapi/external_clear_key/ffmpeg_cdm_audio_decoder.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/filters/chunk_demuxer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M media/filters/decoder_selector.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/filters/fake_video_decoder.h View 1 chunk +0 lines, -4 lines 0 comments Download
M media/filters/ffmpeg_video_decoder.h View 1 chunk +0 lines, -4 lines 0 comments Download
M media/filters/gpu_video_decoder.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/formats/mp2t/es_parser_adts.h View 1 chunk +0 lines, -3 lines 0 comments Download
M media/formats/mp2t/es_parser_h264.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/formats/mp2t/es_parser_mpeg1audio.h View 1 chunk +0 lines, -3 lines 0 comments Download
M media/gpu/avda_shared_state.h View 1 chunk +0 lines, -2 lines 0 comments Download
M media/gpu/ipc/service/gpu_video_encode_accelerator.h View 1 chunk +0 lines, -4 lines 0 comments Download
M media/gpu/ipc/service/media_gpu_channel.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/gpu/ipc/service/media_gpu_channel_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/gpu/v4l2_slice_video_decode_accelerator.h View 1 chunk +0 lines, -4 lines 0 comments Download
M media/gpu/vaapi_picture.h View 1 chunk +0 lines, -4 lines 0 comments Download
M media/gpu/vaapi_tfp_picture.h View 1 chunk +0 lines, -4 lines 0 comments Download
M media/midi/usb_midi_device.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/mojo/services/interface_factory_impl.h View 1 chunk +0 lines, -6 lines 0 comments Download
M media/remoting/remote_renderer_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/renderers/audio_renderer_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/renderers/gpu_video_accelerator_factories.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/renderers/skcanvas_video_renderer.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/test/pipeline_integration_test_base.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 21 (11 generated)
jbriance
4 years ago (2016-11-29 12:55:26 UTC) #3
Takashi Toyoshima
midi lgtm
4 years ago (2016-11-29 13:10:09 UTC) #4
miu
media/cast lgtm
4 years ago (2016-11-29 21:38:40 UTC) #9
miu
...and content/browser/media/capture/web_contents_audio_input_stream_unittest.cc lgtm.
4 years ago (2016-11-29 21:39:07 UTC) #10
sandersd (OOO until July 31)
On 2016/11/29 21:39:07, miu wrote: > ...and content/browser/media/capture/web_contents_audio_input_stream_unittest.cc > lgtm. I won't be able to ...
4 years ago (2016-11-30 02:39:46 UTC) #11
watk
media/ lgtm, thanks! https://codereview.chromium.org/2533273002/diff/1/media/blink/webcontentdecryptionmodule_impl.h File media/blink/webcontentdecryptionmodule_impl.h (right): https://codereview.chromium.org/2533273002/diff/1/media/blink/webcontentdecryptionmodule_impl.h#newcode17 media/blink/webcontentdecryptionmodule_impl.h:17: #include "ppapi/features/features.h" This can go now
4 years ago (2016-11-30 03:15:50 UTC) #13
jbriance
https://codereview.chromium.org/2533273002/diff/1/media/blink/webcontentdecryptionmodule_impl.h File media/blink/webcontentdecryptionmodule_impl.h (right): https://codereview.chromium.org/2533273002/diff/1/media/blink/webcontentdecryptionmodule_impl.h#newcode17 media/blink/webcontentdecryptionmodule_impl.h:17: #include "ppapi/features/features.h" On 2016/11/30 03:15:49, watk wrote: > This ...
4 years ago (2016-11-30 08:01:34 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2533273002/20001
4 years ago (2016-11-30 08:02:45 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-30 09:30:48 UTC) #19
commit-bot: I haz the power
4 years ago (2016-11-30 09:32:33 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/752a7f6980603342771f7e89c7e6717fb59c8954
Cr-Commit-Position: refs/heads/master@{#435198}

Powered by Google App Engine
This is Rietveld 408576698