Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Issue 2533223003: Reland of "WebRtcBrowserTest: Include all stats in getStats." (Closed)

Created:
4 years ago by hbos_chromium
Modified:
4 years ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, phoglund+watch_chromium.org, mcasas+watch+vc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of "WebRtcBrowserTest: Include all stats in getStats." The only stats dictionary that was missing was 'data-channel'. For it to be included data channels had to be created. Added CreateDataChannel to webrtc_browsertest_base.h/cc and peerconnection.js. Unittest updated to EXPECT that no expected stats are missing. Original CL: https://codereview.chromium.org/2527273003/ Reason for revert: A whitelist filter was landed roughly at the same time as the the original CL, causing expected stats to be blacklisted. In this re-land, the whitelist is updated. BUG=chromium:627816 Committed: https://crrev.com/b4b50c8ed64214b9394677426b9ebd1f8a50e2a2 Cr-Commit-Position: refs/heads/master@{#434963}

Patch Set 1 : Original CL #

Patch Set 2 : Whitelist the 'missing' stats #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -3 lines) Patch
M chrome/browser/media/webrtc/webrtc_browsertest.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/media/webrtc/webrtc_browsertest_base.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/media/webrtc/webrtc_browsertest_base.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/test/data/webrtc/peerconnection.js View 1 chunk +9 lines, -0 lines 0 comments Download
M content/renderer/media/webrtc/rtc_stats.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
hbos_chromium
Please take a look, phoglund & hta.
4 years ago (2016-11-29 10:16:58 UTC) #5
phoglund_chromium
lgtm
4 years ago (2016-11-29 10:26:55 UTC) #6
hbos_chromium
On 2016/11/29 10:26:55, phoglund_chrome wrote: > lgtm Landing
4 years ago (2016-11-29 10:27:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2533223003/20001
4 years ago (2016-11-29 10:28:03 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-29 11:57:43 UTC) #13
commit-bot: I haz the power
4 years ago (2016-11-29 12:22:56 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b4b50c8ed64214b9394677426b9ebd1f8a50e2a2
Cr-Commit-Position: refs/heads/master@{#434963}

Powered by Google App Engine
This is Rietveld 408576698