Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Side by Side Diff: chrome/browser/media/webrtc/webrtc_browsertest.cc

Issue 2533223003: Reland of "WebRtcBrowserTest: Include all stats in getStats." (Closed)
Patch Set: Whitelist the 'missing' stats Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/media/webrtc/webrtc_browsertest_base.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "build/build_config.h" 6 #include "build/build_config.h"
7 #include "chrome/browser/media/webrtc/webrtc_browsertest_base.h" 7 #include "chrome/browser/media/webrtc/webrtc_browsertest_base.h"
8 #include "chrome/browser/media/webrtc/webrtc_browsertest_common.h" 8 #include "chrome/browser/media/webrtc/webrtc_browsertest_common.h"
9 #include "chrome/browser/ui/browser.h" 9 #include "chrome/browser/ui/browser.h"
10 #include "chrome/browser/ui/browser_tabstrip.h" 10 #include "chrome/browser/ui/browser_tabstrip.h"
(...skipping 201 matching lines...) Expand 10 before | Expand all | Expand 10 after
212 VerifyStatsGeneratedCallback(left_tab_); 212 VerifyStatsGeneratedCallback(left_tab_);
213 213
214 DetectVideoAndHangUp(); 214 DetectVideoAndHangUp();
215 } 215 }
216 216
217 IN_PROC_BROWSER_TEST_F(WebRtcBrowserTest, 217 IN_PROC_BROWSER_TEST_F(WebRtcBrowserTest,
218 RunsAudioVideoWebRTCCallInTwoTabsGetStatsPromise) { 218 RunsAudioVideoWebRTCCallInTwoTabsGetStatsPromise) {
219 StartServerAndOpenTabs(); 219 StartServerAndOpenTabs();
220 SetupPeerconnectionWithLocalStream(left_tab_); 220 SetupPeerconnectionWithLocalStream(left_tab_);
221 SetupPeerconnectionWithLocalStream(right_tab_); 221 SetupPeerconnectionWithLocalStream(right_tab_);
222 CreateDataChannel(left_tab_, "data");
223 CreateDataChannel(right_tab_, "data");
222 NegotiateCall(left_tab_, right_tab_); 224 NegotiateCall(left_tab_, right_tab_);
223 225
224 std::set<std::string> missing_expected_stats; 226 std::set<std::string> missing_expected_stats;
225 for (const std::string& type : GetWhitelistedStatsTypes(left_tab_)) { 227 for (const std::string& type : GetWhitelistedStatsTypes(left_tab_)) {
226 missing_expected_stats.insert(type); 228 missing_expected_stats.insert(type);
227 } 229 }
228 for (const std::string& type : VerifyStatsGeneratedPromise(left_tab_)) { 230 for (const std::string& type : VerifyStatsGeneratedPromise(left_tab_)) {
229 missing_expected_stats.erase(type); 231 missing_expected_stats.erase(type);
230 } 232 }
231 // TODO(hbos): When all stats are ready and returned by "getStats": 233 for (const std::string& type : missing_expected_stats) {
232 // EXPECT_TRUE(missing_expected_stats.empty()); 234 EXPECT_TRUE(false) << "Expected stats dictionary is missing: " << type;
233 // crbug.com/627816 235 }
234 236
235 DetectVideoAndHangUp(); 237 DetectVideoAndHangUp();
236 } 238 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/media/webrtc/webrtc_browsertest_base.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698