Chromium Code Reviews Chromium Code Reviews
Issue 253313005:
Strip anonymous blocks when change in style removes need for them (Closed)
Base URL: svn://svn.chromium.org/blink/trunk| Index: LayoutTests/fast/block/do-not-strip-anonymous-blocks-when-block-child-becomes-float-and-anonymous-blocks-have-inline-children.html |
| diff --git a/LayoutTests/fast/block/do-not-strip-anonymous-blocks-when-block-child-becomes-float-and-anonymous-blocks-have-inline-children.html b/LayoutTests/fast/block/do-not-strip-anonymous-blocks-when-block-child-becomes-float-and-anonymous-blocks-have-inline-children.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..fe8e920e43eec0c36ad6fea29c0f93e9f509e5fc |
| --- /dev/null |
| +++ b/LayoutTests/fast/block/do-not-strip-anonymous-blocks-when-block-child-becomes-float-and-anonymous-blocks-have-inline-children.html |
| @@ -0,0 +1,44 @@ |
| +<!DOCTYPE html> |
| +<style> |
| + .c2 { position: fixed; } |
|
leviw_travelin_and_unemployed
2014/11/10 21:46:09
Can we get descriptive names instead of c2, c4, c7
|
| + .c4 { -webkit-column-span: all; } |
| + .c7:nth-child(2n+10) { -webkit-column-count: 1; } |
|
leviw_travelin_and_unemployed
2014/11/10 21:46:09
Seems like 2n+10 could also be a smaller #.
|
| + .c7 { padding-left: 65536px; } |
| +</style> |
| +<script> |
| + if (window.testRunner) |
| + testRunner.dumpAsText(); |
| + function boom() { |
| + nav = document.createElement('nav'); |
|
leviw_travelin_and_unemployed
2014/11/10 21:46:09
Add "var" for these variables.
|
| + nav.setAttribute('class', 'c4'); |
| + div.appendChild(nav); |
| + document.body.offsetTop; |
| + |
| + dt.parentNode.removeChild(dt); |
| + |
| + p = document.createElement('p'); |
| + div.appendChild(p); |
| + document.body.offsetTop; |
| + |
| + text = document.createTextNode('88'); |
| + div.appendChild(text); |
| + |
| + p.setAttribute("class", "c2"); |
| + |
| + command = document.createElement('command'); |
| + command.setAttribute('class', 'c7'); |
| + nav.appendChild(command); |
| + } |
| + window.onload = boom; |
| +</script> |
| +<p></p> |
| +<p></p> |
| +<p></p> |
|
leviw_travelin_and_unemployed
2014/11/10 21:46:09
Do we need this many p tags?
|
| +<p></p> |
| +<p></p> |
| +<p></p> |
| +<p></p> |
| +<dt id="dt"></dt> |
| +<p></p> |
| +<div class="c7" id="div"></div> |
| +<p> When a block element becomes positioned or float we should not strip anonymous blocks wrapping its siblings if any of them are not inline.</p> |
