LayoutTests/fast/block/do-not-strip-anonymous-blocks-when-block-child-becomes-float-and-anonymous-blocks-have-inline-children.html - Issue 253313005: Strip anonymous blocks when change in style removes need for them

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/block/do-not-strip-anonymous-blocks-when-block-child-becomes-float-and-anonymous-blocks-have-inline-children.html

Issue 253313005: Strip anonymous blocks when change in style removes need for them (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Updated Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « LayoutTests/TestExpectations ('k') | LayoutTests/fast/block/do-not-strip-anonymous-blocks-when-block-child-becomes-float-and-anonymous-blocks-have-inline-children-expected.txt » ('j') | Source/core/rendering/RenderBlock.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style>

	3 .c2 { position: fixed; }
	leviw_travelin_and_unemployed 2014/11/10 21:46:09 Can we get descriptive names instead of c2, c4, c7 Can we get descriptive names instead of c2, c4, c7,. etc?
	4 .c4 { -webkit-column-span: all; }

	5 .c7:nth-child(2n+10) { -webkit-column-count: 1; }
	leviw_travelin_and_unemployed 2014/11/10 21:46:09 Seems like 2n+10 could also be a smaller #. Seems like 2n+10 could also be a smaller #.
	6 .c7 { padding-left: 65536px; }

	7 </style>

	8 <script>

	9 if (window.testRunner)

	10 testRunner.dumpAsText();

	11 function boom() {

	12 nav = document.createElement('nav');
	leviw_travelin_and_unemployed 2014/11/10 21:46:09 Add "var" for these variables. Add "var" for these variables.
	13 nav.setAttribute('class', 'c4');

	14 div.appendChild(nav);

	15 document.body.offsetTop;

	16

	17 dt.parentNode.removeChild(dt);

	18

	19 p = document.createElement('p');

	20 div.appendChild(p);

	21 document.body.offsetTop;

	22

	23 text = document.createTextNode('88');

	24 div.appendChild(text);

	25

	26 p.setAttribute("class", "c2");

	27

	28 command = document.createElement('command');

	29 command.setAttribute('class', 'c7');

	30 nav.appendChild(command);

	31 }

	32 window.onload = boom;

	33 </script>

	34 <p></p>

	35 <p></p>

	36 <p></p>
	leviw_travelin_and_unemployed 2014/11/10 21:46:09 Do we need this many p tags? Do we need this many p tags?
	37 <p></p>

	38 <p></p>

	39 <p></p>

	40 <p></p>

	41 <dt id="dt"></dt>

	42 <p></p>

	43 <div class="c7" id="div"></div>

	44 <p> When a block element becomes positioned or float we should not strip anonymo us blocks wrapping its siblings if any of them are not inline.</p>

OLD	NEW