Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2533123002: Fix GN missing headers in //base (Closed)

Created:
4 years ago by wychen
Modified:
3 years, 11 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews, extensions-reviews_chromium.org, jam, sadrul, imcheng+watch_chromium.org, mlamouri+watch-content_chromium.org, tfarina, posciak+watch_chromium.org, jasonroberts+watch_google.com, creis+watch_chromium.org, nasko+codewatch_chromium.org, avayvod+watch_chromium.org, feature-media-reviews_chromium.org, Matt Giuca, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, chromium-apps-reviews_chromium.org, kalyank, xjz+watch_chromium.org, native-client-reviews_googlegroups.com, isheriff+watch_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix GN missing headers in //base BUG=661774 Review-Url: https://codereview.chromium.org/2533123002 Cr-Commit-Position: refs/heads/master@{#442626} Committed: https://chromium.googlesource.com/chromium/src/+/7b07e7b5c50594bc8fb536737ce745f1446a57b5

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : fix all //base #

Patch Set 4 : fixup android and linux #

Patch Set 5 : rebase (check_gn_headers validated on CQ here) #

Patch Set 6 : remove dependency on check_gn_headers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -31 lines) Patch
M ash/wm/panels/panel_window_resizer_unittest.cc View 1 2 3 4 2 chunks +4 lines, -1 line 0 comments Download
M base/BUILD.gn View 1 2 3 4 14 chunks +20 lines, -1 line 0 comments Download
M base/debug/stack_trace_posix.cc View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M base/third_party/libevent/BUILD.gn View 1 2 1 chunk +28 lines, -3 lines 0 comments Download
M chrome/browser/apps/app_url_redirector_browsertest.cc View 1 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/component_updater/pnacl_component_installer.cc View 1 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/cast_streaming/performance_test.cc View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/tab_capture/tab_capture_performancetest.cc View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_browsertest.cc View 1 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_loading_browsertest.cc View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/media/encrypted_media_browsertest.cc View 1 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/nacl_host/test/nacl_gdb_browsertest.cc View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/password_manager/password_store_factory.cc View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/create_application_shortcut_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/profiles/new_avatar_button.cc View 1 2 chunks +4 lines, -1 line 0 comments Download
M chrome/common/chrome_paths.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/test/nacl/nacl_browsertest.cc View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/test/ppapi/ppapi_browsertest.cc View 1 2 chunks +4 lines, -1 line 0 comments Download
M components/nacl/browser/nacl_browser.cc View 1 chunk +4 lines, -1 line 0 comments Download
M components/nacl/browser/nacl_process_host.cc View 1 2 3 4 2 chunks +1 line, -1 line 0 comments Download
M components/update_client/update_query_params.cc View 1 chunk +4 lines, -1 line 0 comments Download
M components/update_client/utils.cc View 2 chunks +4 lines, -1 line 0 comments Download
M components/url_formatter/elide_url_unittest.cc View 2 chunks +4 lines, -1 line 0 comments Download
M content/browser/media/encrypted_media_browsertest.cc View 2 chunks +4 lines, -1 line 0 comments Download
M content/common/content_paths.cc View 1 chunk +4 lines, -1 line 0 comments Download
M content/renderer/media/webrtc_audio_device_impl.cc View 1 chunk +4 lines, -1 line 0 comments Download
M content/renderer/render_view_browsertest.cc View 1 2 3 4 2 chunks +4 lines, -1 line 0 comments Download
M ui/app_list/views/app_list_view.cc View 1 2 3 4 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 15 (11 generated)
wychen
PTAL
3 years, 12 months ago (2016-12-28 10:12:10 UTC) #2
brettw
lgtm
3 years, 11 months ago (2016-12-28 16:26:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2533123002/100001
3 years, 11 months ago (2017-01-10 17:43:48 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 17:49:03 UTC) #15
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/7b07e7b5c50594bc8fb536737ce7...

Powered by Google App Engine
This is Rietveld 408576698