Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2533083003: Fix the serialization for values in std::unique_ptrs. (Closed)

Created:
4 years ago by tmarek
Modified:
4 years ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the serialization for values in std::unique_ptrs. In the ToValueImpl specialization for std::unique_ptr<T>, call ToValue with the dereferenced type. All specializations take const&, which would previously result in a call to ToValue(const*&), resulting in a wrong specialization to be selected. BUG=546953 Committed: https://crrev.com/64150c9670bec3824166810fbcb531798b0b9456 Cr-Commit-Position: refs/heads/master@{#434955}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -1 line) Patch
M headless/public/domains/types_unittest.cc View 2 chunks +27 lines, -0 lines 3 comments Download
M headless/public/internal/value_conversions.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
tmarek
4 years ago (2016-11-29 09:54:31 UTC) #3
alex clarke (OOO till 29th)
+ Sami I'm not actually super familiar with the implementation of this stuff, although this ...
4 years ago (2016-11-29 09:58:27 UTC) #5
Sami
Good catch! lgtm with a nit. https://codereview.chromium.org/2533083003/diff/1/headless/public/domains/types_unittest.cc File headless/public/domains/types_unittest.cc (right): https://codereview.chromium.org/2533083003/diff/1/headless/public/domains/types_unittest.cc#newcode234 headless/public/domains/types_unittest.cc:234: ASSERT_NE(nullptr, clone); Please ...
4 years ago (2016-11-29 10:32:21 UTC) #6
tmarek
https://codereview.chromium.org/2533083003/diff/1/headless/public/domains/types_unittest.cc File headless/public/domains/types_unittest.cc (right): https://codereview.chromium.org/2533083003/diff/1/headless/public/domains/types_unittest.cc#newcode234 headless/public/domains/types_unittest.cc:234: ASSERT_NE(nullptr, clone); On 2016/11/29 10:32:21, Sami wrote: > Please ...
4 years ago (2016-11-29 10:36:18 UTC) #7
Sami
https://codereview.chromium.org/2533083003/diff/1/headless/public/domains/types_unittest.cc File headless/public/domains/types_unittest.cc (right): https://codereview.chromium.org/2533083003/diff/1/headless/public/domains/types_unittest.cc#newcode234 headless/public/domains/types_unittest.cc:234: ASSERT_NE(nullptr, clone); On 2016/11/29 10:36:18, tmarek wrote: > On ...
4 years ago (2016-11-29 10:48:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2533083003/1
4 years ago (2016-11-29 10:50:48 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 11:00:57 UTC) #13
commit-bot: I haz the power
4 years ago (2016-11-29 11:02:32 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/64150c9670bec3824166810fbcb531798b0b9456
Cr-Commit-Position: refs/heads/master@{#434955}

Powered by Google App Engine
This is Rietveld 408576698