Fix the serialization for values in std::unique_ptrs.

headless/public/domains/types_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/json/json_reader.h"
+#include "base/json/json_string_value_serializer.h"
 #include "headless/public/devtools/domains/accessibility.h"
+#include "headless/public/devtools/domains/dom.h"
 #include "headless/public/devtools/domains/memory.h"
 #include "headless/public/devtools/domains/page.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace headless {
 
 TEST(TypesTest, IntegerProperty) {
   std::unique_ptr<page::NavigateToHistoryEntryParams> object(
       page::NavigateToHistoryEntryParams::Builder().SetEntryId(123).Build());
   EXPECT_TRUE(object);
@@ skipping 189 matching lines @@
 
   std::unique_ptr<accessibility::AXValue> clone(object->Clone());
   EXPECT_TRUE(clone);
   EXPECT_EQ(base::Value::TYPE_INTEGER, clone->GetValue()->GetType());
 
   int clone_value;
   EXPECT_TRUE(clone->GetValue()->GetAsInteger(&clone_value));
   EXPECT_EQ(123, clone_value);
 }
 
+TEST(TypesTest, ComplexObjectClone) {
+  std::vector<std::unique_ptr<dom::Node>> child_nodes;
+  child_nodes.emplace_back(dom::Node::Builder()
+                               .SetNodeId(1)
+                               .SetBackendNodeId(2)
+                               .SetNodeType(3)
+                               .SetNodeName("-blink-blink")
+                               .SetLocalName("-blink-blink")
+                               .SetNodeValue("-blink-blink")
+                               .Build());
+  std::unique_ptr<dom::SetChildNodesParams> params =
+      dom::SetChildNodesParams::Builder()
+          .SetParentId(123)
+          .SetNodes(std::move(child_nodes))
+          .Build();
+  std::unique_ptr<dom::SetChildNodesParams> clone = params->Clone();
+  ASSERT_NE(nullptr, clone);

[Sami, 2016/11/29 10:32:21]

Please use EXPECT_NE instead of ASSERT_NE so that the test keeps going even if
this check fails.

[tmarek, 2016/11/29 10:36:18]

The test will crash with a SEGV (ptr is dereferenced on line 239) when this
assertion fails, potentially keeping other test cases from running.

[Sami, 2016/11/29 10:48:04]

Fair point. We generally avoid asserts in tests but I now think this one is
fine.

+
+  std::string orig;
+  JSONStringValueSerializer(&orig).Serialize(*params->Serialize());
+  std::string clone_value;
+  JSONStringValueSerializer(&clone_value).Serialize(*clone->Serialize());
+  EXPECT_EQ(orig, clone_value);
+}
+
 }  // namespace headless