Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Unified Diff: ash/common/system/tray/tray_popup_utils.cc

Issue 2533053002: Handle view resize for ripple (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/common/system/tray/tray_popup_utils.cc
diff --git a/ash/common/system/tray/tray_popup_utils.cc b/ash/common/system/tray/tray_popup_utils.cc
index a7cda5a74fec0bd57c525c16bb061856ee7a0b44..43c4ade07a205acc6dc61ce54399a099185775c1 100644
--- a/ash/common/system/tray/tray_popup_utils.cc
+++ b/ash/common/system/tray/tray_popup_utils.cc
@@ -329,6 +329,7 @@ std::unique_ptr<views::InkDropRipple> TrayPopupUtils::CreateInkDropRipple(
const gfx::Point& center_point) {
const gfx::Rect bounds =
TrayPopupUtils::GetInkDropBounds(ink_drop_style, host);
+ const gfx::Insets insets = TrayPopupUtils::GetInkDropInsets(ink_drop_style);
bruthig 2016/11/28 22:13:45 nit: Can you tighten the scope for |insets|. i.e.
mohsen 2016/11/29 00:07:12 Done.
switch (ink_drop_style) {
case TrayPopupInkDropStyle::HOST_CENTERED:
if (MaterialDesignController::GetMode() ==
@@ -342,7 +343,7 @@ std::unique_ptr<views::InkDropRipple> TrayPopupUtils::CreateInkDropRipple(
case TrayPopupInkDropStyle::INSET_BOUNDS:
case TrayPopupInkDropStyle::FILL_BOUNDS:
return base::MakeUnique<views::FloodFillInkDropRipple>(
- bounds, center_point, kTrayPopupInkDropBaseColor,
+ host->size(), insets, center_point, kTrayPopupInkDropBaseColor,
kTrayPopupInkDropRippleOpacity);
}
// Required for some compilers.

Powered by Google App Engine
This is Rietveld 408576698