Handle view resize for ripple

ash/common/system/tray/tray_popup_utils.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/common/system/tray/tray_popup_utils.h"
 
 #include "ash/common/ash_constants.h"
 #include "ash/common/ash_view_ids.h"
 #include "ash/common/material_design/material_design_controller.h"
 #include "ash/common/session/session_state_delegate.h"
@@ skipping 311 matching lines @@
 
   return std::move(ink_drop);
 }
 
 std::unique_ptr<views::InkDropRipple> TrayPopupUtils::CreateInkDropRipple(
     TrayPopupInkDropStyle ink_drop_style,
     const views::View* host,
     const gfx::Point& center_point) {
   const gfx::Rect bounds =
       TrayPopupUtils::GetInkDropBounds(ink_drop_style, host);
+  const gfx::Insets insets = TrayPopupUtils::GetInkDropInsets(ink_drop_style);

[bruthig, 2016/11/28 22:13:45]

nit: Can you tighten the scope for |insets|. i.e. add curly braces to the
INSET_BOUNDS/FILL_BOUNDS case so you can make |insets| a local var within that
scope. Or just call GetInkDropInsets() inline in the FloodFillInkDropRipple
ctor.

[mohsen, 2016/11/29 00:07:12]

Done.

   switch (ink_drop_style) {
     case TrayPopupInkDropStyle::HOST_CENTERED:
       if (MaterialDesignController::GetMode() ==
           MaterialDesignController::MATERIAL_EXPERIMENTAL) {
         return base::MakeUnique<views::SquareInkDropRipple>(
             bounds.size(), bounds.size().width() / 2, bounds.size(),
             bounds.size().width() / 2, center_point, bounds.CenterPoint(),
             kTrayPopupInkDropBaseColor, kTrayPopupInkDropRippleOpacity);
       }
     // Intentional fall through.
     case TrayPopupInkDropStyle::INSET_BOUNDS:
     case TrayPopupInkDropStyle::FILL_BOUNDS:
       return base::MakeUnique<views::FloodFillInkDropRipple>(
-          bounds, center_point, kTrayPopupInkDropBaseColor,
+          host->size(), insets, center_point, kTrayPopupInkDropBaseColor,
           kTrayPopupInkDropRippleOpacity);
   }
   // Required for some compilers.
   NOTREACHED();
   return nullptr;
 }
 
 std::unique_ptr<views::InkDropHighlight> TrayPopupUtils::CreateInkDropHighlight(
     TrayPopupInkDropStyle ink_drop_style,
     const views::View* host) {
@@ skipping 74 matching lines @@
 bool TrayPopupUtils::CanOpenWebUISettings(LoginStatus status) {
   // TODO(tdanderson): Consider moving this into WmShell, or introduce a
   // CanShowSettings() method in each delegate type that has a
   // ShowSettings() method.
   return status != LoginStatus::NOT_LOGGED_IN &&
          status != LoginStatus::LOCKED &&
          !WmShell::Get()->GetSessionStateDelegate()->IsInSecondaryLoginScreen();
 }
 
 }  // namespace ash