Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issue 2532953010: Merge to m56: Re-add the line break attribute (Closed)

Created:
4 years ago by David Tseng
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews, extensions-reviews_chromium.org, alemate+watch_chromium.org, dtseng+watch_chromium.org, mlamouri+watch-content_chromium.org, aboxhall+watch_chromium.org, jam, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, darin-cc_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, dmazzoni+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Merge to m56: Re-add the line break attribute This cl restores the line break attribute as it was calculated in the past. Once we implement something based on the AX-tree that covers all bases, this can be safely removed. TEST=chromevox_tests; manually over various examples CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2526073003 Cr-Commit-Position: refs/heads/master@{#434747} (cherry picked from commit 7823f3cdcb5cdc467d8362673e205bac71953320) BUG=669134 TBR=dtseng@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/0f80b428935374e97a06c9ffb53616ffa1054bc5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -45 lines) Patch
M chrome/browser/resources/chromeos/chromevox/common/chrome_extension_externs.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/editing.js View 2 chunks +8 lines, -44 lines 0 comments Download
M chrome/renderer/resources/extensions/automation/automation_node.js View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/accessibility/blink_ax_tree_source.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M ui/accessibility/ax_enums.idl View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/accessibility/ax_node_data.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/accessibility/ax_tree_combiner.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (3 generated)
David Tseng
4 years ago (2016-11-30 23:05:19 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0f80b428935374e97a06c9ffb53616ffa1054bc5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698