Re-add the line break attribute

Re-add the line break attribute

This cl restores the line break attribute as it was calculated in the past. Once we implement something based on the AX-tree that covers all bases, this can be safely removed.

TEST=chromevox_tests; manually over various examples
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/7823f3cdcb5cdc467d8362673e205bac71953320
Cr-Commit-Position: refs/heads/master@{#434747}

[David Tseng, 2016-11-23 23:16:30]

Description was changed from

==========
--file=/tmp/m

BUG=
==========

to

==========
--file=/tmp/m

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-11-23 23:17:40]

Description was changed from

==========
--file=/tmp/m

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Re-add the line break attribute

This cl restores the line break attribute as it was calculated in the past. Once
we implement something based on the AX-tree that covers all bases, this can be
safely removed.

TEST=chromevox_tests; manually over various examples
==========

[David Tseng, 2016-11-23 23:17:40]

dtseng@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[David Tseng, 2016-11-23 23:22:46]

The CQ bit was checked by dtseng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 23:23:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 23:39:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 23:39:49]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[David Tseng, 2016-11-23 23:41:57]

The CQ bit was checked by dtseng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 23:42:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 23:48:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 23:48:04]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[dmazzoni, 2016-11-28 17:41:38]

lgtm

https://codereview.chromium.org/2526073003/diff/1/content/renderer/accessibil...
File content/renderer/accessibility/blink_ax_tree_source.cc (right):

https://codereview.chromium.org/2526073003/diff/1/content/renderer/accessibil...
content/renderer/accessibility/blink_ax_tree_source.cc:551: #if
defined(OS_CHROMEOS)
Add a comment with a bug link

https://codereview.chromium.org/2526073003/diff/1/content/renderer/accessibil...
content/renderer/accessibility/blink_ax_tree_source.cc:561: }
I think this closing brace belongs outside of the ifdef

https://codereview.chromium.org/2526073003/diff/1/ui/accessibility/ax_enums.idl
File ui/accessibility/ax_enums.idl (right):

https://codereview.chromium.org/2526073003/diff/1/ui/accessibility/ax_enums.i...
ui/accessibility/ax_enums.idl:450: // this attribute is only available on Chrome
OS and will be depricated
depricated -> deprecated

[David Tseng, 2016-11-28 19:13:01]

https://codereview.chromium.org/2526073003/diff/1/content/renderer/accessibil...
File content/renderer/accessibility/blink_ax_tree_source.cc (right):

https://codereview.chromium.org/2526073003/diff/1/content/renderer/accessibil...
content/renderer/accessibility/blink_ax_tree_source.cc:551: #if
defined(OS_CHROMEOS)
On 2016/11/28 17:41:38, dmazzoni wrote:
> Add a comment with a bug link

Done.

https://codereview.chromium.org/2526073003/diff/1/content/renderer/accessibil...
content/renderer/accessibility/blink_ax_tree_source.cc:561: }
On 2016/11/28 17:41:38, dmazzoni wrote:
> I think this closing brace belongs outside of the ifdef

Done.

https://codereview.chromium.org/2526073003/diff/1/ui/accessibility/ax_enums.idl
File ui/accessibility/ax_enums.idl (right):

https://codereview.chromium.org/2526073003/diff/1/ui/accessibility/ax_enums.i...
ui/accessibility/ax_enums.idl:450: // this attribute is only available on Chrome
OS and will be depricated
On 2016/11/28 17:41:38, dmazzoni wrote:
> depricated -> deprecated

Done.

[David Tseng, 2016-11-28 19:13:25]

Description was changed from

==========
Re-add the line break attribute

This cl restores the line break attribute as it was calculated in the past. Once
we implement something based on the AX-tree that covers all bases, this can be
safely removed.

TEST=chromevox_tests; manually over various examples
==========

to

==========
Re-add the line break attribute

This cl restores the line break attribute as it was calculated in the past. Once
we implement something based on the AX-tree that covers all bases, this can be
safely removed.

TEST=chromevox_tests; manually over various examples
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-11-28 19:13:36]

The CQ bit was checked by dtseng@chromium.org

[David Tseng, 2016-11-28 19:13:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2526073003/#ps20001
(title: "--file=/tmp/m")

[commit-bot: I haz the power, 2016-11-28 19:14:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 19:45:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 19:45:18]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, no
build URL)

[David Tseng, 2016-11-28 20:09:02]

The CQ bit was checked by dtseng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-28 20:10:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[David Tseng, 2016-11-28 21:53:31]

The CQ bit was unchecked by dtseng@chromium.org

[David Tseng, 2016-11-28 21:53:32]

The CQ bit was checked by dtseng@chromium.org

[commit-bot: I haz the power, 2016-11-28 21:55:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 22:42:42]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480370012348440,
"parent_rev": "9c59aadce0c0916fe69e510feaa1fc2d50fbb04f", "commit_rev":
"f95730dc3cc042a73a86b79f095106c92da49e04"}

[commit-bot: I haz the power, 2016-11-28 22:43:12]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-28 22:46:42]

Description was changed from

==========
Re-add the line break attribute

This cl restores the line break attribute as it was calculated in the past. Once
we implement something based on the AX-tree that covers all bases, this can be
safely removed.

TEST=chromevox_tests; manually over various examples
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Re-add the line break attribute

This cl restores the line break attribute as it was calculated in the past. Once
we implement something based on the AX-tree that covers all bases, this can be
safely removed.

TEST=chromevox_tests; manually over various examples
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/7823f3cdcb5cdc467d8362673e205bac71953320
Cr-Commit-Position: refs/heads/master@{#434747}
==========

[commit-bot: I haz the power, 2016-11-28 22:46:44]

Patchset 2 (id:??) landed as
https://crrev.com/7823f3cdcb5cdc467d8362673e205bac71953320
Cr-Commit-Position: refs/heads/master@{#434747}