RtcVideoDecoder: do not fallback to software when getting size 0x0 keyframe.

RtcVideoDecoder: do not fallback to software when getting size 0x0 keyframe.

A keyframe doesn't mean it has a resolution like IDR. On the
other hand, SPS is not a keyframe but it has a resolution.
Size 0x0 is not a new resolution and we should not fallback
to software decoder.

BUG=653434
TEST=H264/VP8 apprtc loopback and Hangout on Sentry and Elm.

Committed: https://crrev.com/91f58a78aa62ea4b6e3a81a98f017fdc1c0ed644
Cr-Commit-Position: refs/heads/master@{#435901}

[wuchengli, 2016-11-30 13:58:40]

wuchengli@chromium.org changed reviewers:
+ holmer@chromium.org, posciak@chromium.org

[wuchengli, 2016-11-30 14:04:22]

The CQ bit was checked by wuchengli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-30 14:04:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[wuchengli, 2016-11-30 14:12:13]

Description was changed from

==========
RtcVideoDecoder: do not fallback to software when getting size 0x0 keyframe.

BUG=653434
TEST=H264 apprtc loopback on Sentry.
==========

to

==========
RtcVideoDecoder: do not fallback to software when getting size 0x0 keyframe.

BUG=653434
TEST=H264 apprtc loopback on Sentry.
==========

[wuchengli, 2016-11-30 14:12:13]

wuchengli@chromium.org changed reviewers:
- holmer@chromium.org

[Stefan, 2016-11-30 15:02:20]

holmer@chromium.org changed reviewers:
+ holmer@chromium.org

[Stefan, 2016-11-30 15:02:21]

lgtm

[commit-bot: I haz the power, 2016-11-30 15:02:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 15:02:32]

Dry run: This issue passed the CQ dry run.

[wuchengli, 2016-12-01 08:47:48]

Description was changed from

==========
RtcVideoDecoder: do not fallback to software when getting size 0x0 keyframe.

BUG=653434
TEST=H264 apprtc loopback on Sentry.
==========

to

==========
RtcVideoDecoder: do not fallback to software when getting size 0x0 keyframe.

A keyframe doesn't mean it has a resolution like IDR. On the
other hand, SPS is not a keyframe but it has a resolution.
Size 0x0 is not a new resolution and we should not fallback
to software decoder.

BUG=653434
TEST=H264 apprtc loopback and Hangout on Sentry and Elm.
==========

[wuchengli, 2016-12-01 08:48:17]

PTAL

[Pawel Osciak, 2016-12-02 00:13:00]

lgtm % nit, but please also test vp8 loopback just in case.

https://codereview.chromium.org/2532953009/diff/40001/content/renderer/media/...
File content/renderer/media/gpu/rtc_video_decoder.cc (right):

https://codereview.chromium.org/2532953009/diff/40001/content/renderer/media/...
content/renderer/media/gpu/rtc_video_decoder.cc:215: if
(!new_frame_size.IsEmpty()) {
if (!new_frame_size.IsEmpty() && new_frame_size != frame_size_) {

[wuchengli, 2016-12-02 05:54:40]

Description was changed from

==========
RtcVideoDecoder: do not fallback to software when getting size 0x0 keyframe.

A keyframe doesn't mean it has a resolution like IDR. On the
other hand, SPS is not a keyframe but it has a resolution.
Size 0x0 is not a new resolution and we should not fallback
to software decoder.

BUG=653434
TEST=H264 apprtc loopback and Hangout on Sentry and Elm.
==========

to

==========
RtcVideoDecoder: do not fallback to software when getting size 0x0 keyframe.

A keyframe doesn't mean it has a resolution like IDR. On the
other hand, SPS is not a keyframe but it has a resolution.
Size 0x0 is not a new resolution and we should not fallback
to software decoder.

BUG=653434
TEST=H264/VP8 apprtc loopback and Hangout on Sentry and Elm.
==========

[wuchengli, 2016-12-02 05:54:48]

Done.

https://codereview.chromium.org/2532953009/diff/40001/content/renderer/media/...
File content/renderer/media/gpu/rtc_video_decoder.cc (right):

https://codereview.chromium.org/2532953009/diff/40001/content/renderer/media/...
content/renderer/media/gpu/rtc_video_decoder.cc:215: if
(!new_frame_size.IsEmpty()) {
On 2016/12/02 00:13:00, Pawel Osciak wrote:
> if (!new_frame_size.IsEmpty() && new_frame_size != frame_size_) {

Done.

[wuchengli, 2016-12-02 05:54:53]

The CQ bit was checked by wuchengli@chromium.org

[wuchengli, 2016-12-02 05:54:55]

The patchset sent to the CQ was uploaded after l-g-t-m from holmer@chromium.org,
posciak@chromium.org
Link to the patchset: https://codereview.chromium.org/2532953009/#ps60001
(title: "address Pawel's comments")

[commit-bot: I haz the power, 2016-12-02 05:55:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 06:17:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 06:17:37]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[wuchengli, 2016-12-02 06:50:01]

The CQ bit was checked by wuchengli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 06:50:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 07:10:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 07:10:46]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[wuchengli, 2016-12-02 07:33:14]

The CQ bit was checked by wuchengli@chromium.org

[commit-bot: I haz the power, 2016-12-02 07:33:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 07:45:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 07:45:16]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[wuchengli, 2016-12-02 08:51:49]

The CQ bit was checked by wuchengli@chromium.org

[wuchengli, 2016-12-02 08:51:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
posciak@chromium.org, holmer@chromium.org
Link to the patchset: https://codereview.chromium.org/2532953009/#ps80001
(title: "fix the test")

[commit-bot: I haz the power, 2016-12-02 08:52:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 10:06:04]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1480668709259270,
"parent_rev": "89ec25bcbf8a5ff6af8a0836b7d987cbf19bafbc", "commit_rev":
"cb411e4b842a444016b81bc75552683fc1eea247"}

[commit-bot: I haz the power, 2016-12-02 10:06:34]

Description was changed from

==========
RtcVideoDecoder: do not fallback to software when getting size 0x0 keyframe.

A keyframe doesn't mean it has a resolution like IDR. On the
other hand, SPS is not a keyframe but it has a resolution.
Size 0x0 is not a new resolution and we should not fallback
to software decoder.

BUG=653434
TEST=H264/VP8 apprtc loopback and Hangout on Sentry and Elm.
==========

to

==========
RtcVideoDecoder: do not fallback to software when getting size 0x0 keyframe.

A keyframe doesn't mean it has a resolution like IDR. On the
other hand, SPS is not a keyframe but it has a resolution.
Size 0x0 is not a new resolution and we should not fallback
to software decoder.

BUG=653434
TEST=H264/VP8 apprtc loopback and Hangout on Sentry and Elm.
==========

[commit-bot: I haz the power, 2016-12-02 10:06:35]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-12-02 10:08:49]

Description was changed from

==========
RtcVideoDecoder: do not fallback to software when getting size 0x0 keyframe.

A keyframe doesn't mean it has a resolution like IDR. On the
other hand, SPS is not a keyframe but it has a resolution.
Size 0x0 is not a new resolution and we should not fallback
to software decoder.

BUG=653434
TEST=H264/VP8 apprtc loopback and Hangout on Sentry and Elm.
==========

to

==========
RtcVideoDecoder: do not fallback to software when getting size 0x0 keyframe.

A keyframe doesn't mean it has a resolution like IDR. On the
other hand, SPS is not a keyframe but it has a resolution.
Size 0x0 is not a new resolution and we should not fallback
to software decoder.

BUG=653434
TEST=H264/VP8 apprtc loopback and Hangout on Sentry and Elm.

Committed: https://crrev.com/91f58a78aa62ea4b6e3a81a98f017fdc1c0ed644
Cr-Commit-Position: refs/heads/master@{#435901}
==========

[commit-bot: I haz the power, 2016-12-02 10:08:50]

Patchset 5 (id:??) landed as
https://crrev.com/91f58a78aa62ea4b6e3a81a98f017fdc1c0ed644
Cr-Commit-Position: refs/heads/master@{#435901}