Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2724)

Unified Diff: content/renderer/media/gpu/rtc_video_decoder_unittest.cc

Issue 2532953009: RtcVideoDecoder: do not fallback to software when getting size 0x0 keyframe. (Closed)
Patch Set: fix the test Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/media/gpu/rtc_video_decoder.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/gpu/rtc_video_decoder_unittest.cc
diff --git a/content/renderer/media/gpu/rtc_video_decoder_unittest.cc b/content/renderer/media/gpu/rtc_video_decoder_unittest.cc
index 877d457c8d288c7c48aaeb68eab7619368601a7e..7fdbb910cbab8117a57f2bda01af07b7873904a2 100644
--- a/content/renderer/media/gpu/rtc_video_decoder_unittest.cc
+++ b/content/renderer/media/gpu/rtc_video_decoder_unittest.cc
@@ -291,8 +291,8 @@ TEST_P(RTCVideoDecoderTest, GetVDAErrorCounterForTesting) {
webrtc::EncodedImage input_image;
input_image._completeFrame = true;
- input_image._encodedWidth = kMinResolutionWidth;
- input_image._encodedHeight = kMaxResolutionHeight;
+ input_image._encodedWidth = 0;
+ input_image._encodedHeight = 0;
input_image._frameType = webrtc::kVideoFrameDelta;
input_image._length = kMinResolutionWidth * kMaxResolutionHeight;
EXPECT_EQ(WEBRTC_VIDEO_CODEC_ERROR,
@@ -310,8 +310,8 @@ TEST_P(RTCVideoDecoderTest, GetVDAErrorCounterForTesting) {
rtc_decoder_->Decode(input_image, false, nullptr, nullptr, 0));
EXPECT_EQ(1, rtc_decoder_->GetVDAErrorCounterForTesting());
- // Decoder expects a keyframe after reset, so drops any other frames. However,
- // we should still increment the error counter.
+ // Decoder expects a frame with size after reset, so drops any other frames.
+ // However, we should still increment the error counter.
EXPECT_EQ(WEBRTC_VIDEO_CODEC_ERROR,
rtc_decoder_->Decode(input_image, false, nullptr, nullptr, 0));
EXPECT_EQ(2, rtc_decoder_->GetVDAErrorCounterForTesting());
« no previous file with comments | « content/renderer/media/gpu/rtc_video_decoder.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698