Apply custom property animations

Apply custom property animations

This change enables CSS and Web animations to apply animated
effects on CSS custom properties.

This change involves a restructure of style resolving detailed
in the design doc:
https://docs.google.com/a/chromium.org/document/d/1V27q30H-pQZVbzHCJjdFThBSeuvxkGLdGmb1hLWBAiY

This is a reland of https://codereview.chromium.org/2309963002
with fixes for when the baseComputedStyle optimisation is active.
The revert was due to crbug.com/669790 where behaviour differs
depending on whether asserts are enabled, thus none of the try
bots picked up on the bug.

BUG=644148
Committed: https://crrev.com/f9262a06c8d1e0478cbf2cc84a1b29f86d9d89e4
Cr-Commit-Position: refs/heads/master@{#436235}

[alancutter (OOO until 2018), 2016-11-30 06:01:58]

Description was changed from

==========
Apply custom property animations

This change enables CSS and Web animations to apply animated
effects on CSS custom properties.

This change involves a restructure of style resolving detailed
in the design doc:
https://docs.google.com/a/chromium.org/document/d/1V27q30H-pQZVbzHCJjdFThBSeu...

This is a reland of https://codereview.chromium.org/2309963002 with fixes
for when the baseComputedStyle optimisation is active.

BUG=644148
==========

to

==========
Apply custom property animations

This change enables CSS and Web animations to apply animated
effects on CSS custom properties.

This change involves a restructure of style resolving detailed
in the design doc:
https://docs.google.com/a/chromium.org/document/d/1V27q30H-pQZVbzHCJjdFThBSeu...

This is a reland of https://codereview.chromium.org/2309963002
with fixes for when the baseComputedStyle optimisation is active.

BUG=644148
==========

[alancutter (OOO until 2018), 2016-11-30 06:08:15]

alancutter@chromium.org changed reviewers:
+ timloh@chromium.org

[alancutter (OOO until 2018), 2016-11-30 06:08:16]

PTAL at the revised version of https://codereview.chromium.org/2309963002.
The changes from the previous patch are:
 - checkAnimationProperties in CSSAnimations::calculateAnimationUpdate()
   This ensures that calculateAnimationActiveInterpolations() is still called in
animation style recalcs.
 - Checking state.isAnimationInterpolationMapReady() in
StyleResolver::applyAnimatedStandardProperties()
   This ensures that calculateAnimationActiveInterpolations() is still called
when the baseComputedStyle optimisation is active.

Both scenarios "in animation style recalc" and "baseComputedStyle optimisation
is active" had #if DCHECK_IS_ON() code segments that hid these bugs from the
tests with asserts enabled. Without asserts enabled many many tests fail.

[suzyh_UTC10 (ex-contributor), 2016-11-30 21:56:08]

On 2016/11/30 at 06:08:16, alancutter wrote:
> PTAL at the revised version of https://codereview.chromium.org/2309963002.
> The changes from the previous patch are:
>  - checkAnimationProperties in CSSAnimations::calculateAnimationUpdate()
>    This ensures that calculateAnimationActiveInterpolations() is still called
in animation style recalcs.
>  - Checking state.isAnimationInterpolationMapReady() in
StyleResolver::applyAnimatedStandardProperties()
>    This ensures that calculateAnimationActiveInterpolations() is still called
when the baseComputedStyle optimisation is active.
> 
> Both scenarios "in animation style recalc" and "baseComputedStyle optimisation
is active" had #if DCHECK_IS_ON() code segments that hid these bugs from the
tests with asserts enabled. Without asserts enabled many many tests fail.

For the record, Alan filed
https://bugs.chromium.org/p/chromium/issues/detail?id=669790 to track this
issue. I suggest also referring to it in the CL description and bug for this
patch for extra trails.

[alancutter (OOO until 2018), 2016-11-30 22:24:45]

Description was changed from

==========
Apply custom property animations

This change enables CSS and Web animations to apply animated
effects on CSS custom properties.

This change involves a restructure of style resolving detailed
in the design doc:
https://docs.google.com/a/chromium.org/document/d/1V27q30H-pQZVbzHCJjdFThBSeu...

This is a reland of https://codereview.chromium.org/2309963002
with fixes for when the baseComputedStyle optimisation is active.

BUG=644148
==========

to

==========
Apply custom property animations

This change enables CSS and Web animations to apply animated
effects on CSS custom properties.

This change involves a restructure of style resolving detailed
in the design doc:
https://docs.google.com/a/chromium.org/document/d/1V27q30H-pQZVbzHCJjdFThBSeu...

This is a reland of https://codereview.chromium.org/2309963002
with fixes for when the baseComputedStyle optimisation is active.
The revert was due to crbug.com/669790 where behaviour differs
depending on whether asserts are enabled, thus none of the try
bots picked up on the bug.

BUG=644148
==========

[alancutter (OOO until 2018), 2016-11-30 22:24:57]

On 2016/11/30 at 21:56:08, suzyh wrote:
> On 2016/11/30 at 06:08:16, alancutter wrote:
> > PTAL at the revised version of https://codereview.chromium.org/2309963002.
> > The changes from the previous patch are:
> >  - checkAnimationProperties in CSSAnimations::calculateAnimationUpdate()
> >    This ensures that calculateAnimationActiveInterpolations() is still
called in animation style recalcs.
> >  - Checking state.isAnimationInterpolationMapReady() in
StyleResolver::applyAnimatedStandardProperties()
> >    This ensures that calculateAnimationActiveInterpolations() is still
called when the baseComputedStyle optimisation is active.
> > 
> > Both scenarios "in animation style recalc" and "baseComputedStyle
optimisation is active" had #if DCHECK_IS_ON() code segments that hid these bugs
from the tests with asserts enabled. Without asserts enabled many many tests
fail.
> 
> For the record, Alan filed
https://bugs.chromium.org/p/chromium/issues/detail?id=669790 to track this
issue. I suggest also referring to it in the CL description and bug for this
patch for extra trails.

Done.

[Timothy Loh, 2016-12-01 03:41:48]

lgtm but next time upload the original patch first so they can be diffed between
:\

https://codereview.chromium.org/2532953008/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp (right):

https://codereview.chromium.org/2532953008/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp:325:
checkAnimationProperties = false;
maybe just calculateAnimationActiveInterpolations+return here to keep the diff
smaller :/

[alancutter (OOO until 2018), 2016-12-01 04:27:02]

The CQ bit was checked by alancutter@chromium.org

[alancutter (OOO until 2018), 2016-12-01 04:27:02]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/2532953008/#ps20001
(title: "Review change")

[commit-bot: I haz the power, 2016-12-01 04:27:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 05:22:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 05:23:00]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[alancutter (OOO until 2018), 2016-12-01 06:11:48]

The CQ bit was checked by alancutter@chromium.org

[alancutter (OOO until 2018), 2016-12-01 06:11:49]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/2532953008/#ps40001
(title: "Fix early out logic")

[commit-bot: I haz the power, 2016-12-01 06:11:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 06:54:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 06:54:01]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[alancutter (OOO until 2018), 2016-12-01 07:27:43]

The CQ bit was checked by alancutter@chromium.org

[alancutter (OOO until 2018), 2016-12-01 07:27:43]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/2532953008/#ps60001
(title: "Fix moar")

[commit-bot: I haz the power, 2016-12-01 07:28:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 07:41:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 07:41:58]

Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[alancutter (OOO until 2018), 2016-12-02 08:07:33]

The CQ bit was checked by alancutter@chromium.org

[alancutter (OOO until 2018), 2016-12-02 08:07:34]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/2532953008/#ps80001
(title: "Fix compile")

[commit-bot: I haz the power, 2016-12-02 08:07:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 09:26:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 09:26:21]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[alancutter (OOO until 2018), 2016-12-05 04:21:33]

The CQ bit was checked by alancutter@chromium.org

[alancutter (OOO until 2018), 2016-12-05 04:21:34]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/2532953008/#ps100001
(title: "Make animatedElement usage consistent")

[commit-bot: I haz the power, 2016-12-05 04:21:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 05:51:19]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1480911693587430,
"parent_rev": "d5b681c77ca1a83a0833e1d25a766b00ea52544e", "commit_rev":
"7de1581afaa365ef604277bc5c6c068353e74bad"}

[commit-bot: I haz the power, 2016-12-05 05:52:14]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-12-05 05:53:49]

Description was changed from

==========
Apply custom property animations

This change enables CSS and Web animations to apply animated
effects on CSS custom properties.

This change involves a restructure of style resolving detailed
in the design doc:
https://docs.google.com/a/chromium.org/document/d/1V27q30H-pQZVbzHCJjdFThBSeu...

This is a reland of https://codereview.chromium.org/2309963002
with fixes for when the baseComputedStyle optimisation is active.
The revert was due to crbug.com/669790 where behaviour differs
depending on whether asserts are enabled, thus none of the try
bots picked up on the bug.

BUG=644148
==========

to

==========
Apply custom property animations

This change enables CSS and Web animations to apply animated
effects on CSS custom properties.

This change involves a restructure of style resolving detailed
in the design doc:
https://docs.google.com/a/chromium.org/document/d/1V27q30H-pQZVbzHCJjdFThBSeu...

This is a reland of https://codereview.chromium.org/2309963002
with fixes for when the baseComputedStyle optimisation is active.
The revert was due to crbug.com/669790 where behaviour differs
depending on whether asserts are enabled, thus none of the try
bots picked up on the bug.

BUG=644148

Committed: https://crrev.com/f9262a06c8d1e0478cbf2cc84a1b29f86d9d89e4
Cr-Commit-Position: refs/heads/master@{#436235}
==========

[commit-bot: I haz the power, 2016-12-05 05:53:50]

Patchset 6 (id:??) landed as
https://crrev.com/f9262a06c8d1e0478cbf2cc84a1b29f86d9d89e4
Cr-Commit-Position: refs/heads/master@{#436235}