Apply custom property animation

Apply custom property animations

This change enables CSS and Web animations to apply animated
effects on CSS custom properties.

This change involves a restructure of style resolving detailed
in the design doc:
https://docs.google.com/a/chromium.org/document/d/1V27q30H-pQZVbzHCJjdFThBSeuvxkGLdGmb1hLWBAiY

BUG=644148
Committed: https://crrev.com/99118e5d645f046aa132529f6189a850c5b8ed49
Cr-Commit-Position: refs/heads/master@{#434122}

[alancutter (OOO until 2018), 2016-10-11 02:15:31]

CL for src perf tryjob to run blink_style.top_25 benchmark on linux platform(s)

[alancutter (OOO until 2018), 2016-10-21 05:17:34]

Description was changed from

==========
[WIP] Apply custom properties in CSS/Web Animations

BUG=644148
==========

to

==========
Apply custom property animation

This change enables CSS and Web animations to apply animated
effects on CSS custom properties.

This change refactors style resolution to compute and apply CSS
animations and custom property animation prior to resolving the
computed values of high and low priority properties.

BUG=644148
==========

[alancutter (OOO until 2018), 2016-10-21 05:17:34]

alancutter@chromium.org changed reviewers:
+ timloh@chromium.org

[alancutter (OOO until 2018), 2016-10-21 05:17:59]

The CQ bit was checked by alancutter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 05:18:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 06:59:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 06:59:24]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[alancutter (OOO until 2018), 2016-11-16 00:53:35]

Description was changed from

==========
Apply custom property animation

This change enables CSS and Web animations to apply animated
effects on CSS custom properties.

This change refactors style resolution to compute and apply CSS
animations and custom property animation prior to resolving the
computed values of high and low priority properties.

BUG=644148
==========

to

==========
Apply custom property animations

This change enables CSS and Web animations to apply animated
effects on CSS custom properties.

This change involves a restructure of style resolving detailed
in the design doc:
https://docs.google.com/a/chromium.org/document/d/1V27q30H-pQZVbzHCJjdFThBSeu...

BUG=644148
==========

[alancutter (OOO until 2018), 2016-11-16 05:24:01]

The CQ bit was checked by alancutter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 05:24:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[alancutter (OOO until 2018), 2016-11-17 00:49:45]

The CQ bit was checked by alancutter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 00:51:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 02:53:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 02:53:21]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_TIMED_OUT,
no build URL)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_TIMED_OUT,
no build URL)
  android_compile_dbg on master.tryserver.chromium.android (JOB_TIMED_OUT, no
build URL)
  android_cronet on master.tryserver.chromium.android (JOB_TIMED_OUT, no build
URL)
  cast_shell_android on master.tryserver.chromium.android (JOB_TIMED_OUT, no
build URL)

[alancutter (OOO until 2018), 2016-11-17 22:17:54]

timloh: Ping.

[Timothy Loh, 2016-11-22 07:34:46]

On 2016/11/17 22:17:54, alancutter wrote:
> timloh: Ping.

lgtm

[alancutter (OOO until 2018), 2016-11-22 23:14:02]

The CQ bit was checked by alancutter@chromium.org

[commit-bot: I haz the power, 2016-11-22 23:14:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 01:31:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 01:31:05]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[alancutter (OOO until 2018), 2016-11-23 03:52:38]

The CQ bit was checked by alancutter@chromium.org

[alancutter (OOO until 2018), 2016-11-23 03:52:39]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/2309963002/#ps280001
(title: "Rebase")

[commit-bot: I haz the power, 2016-11-23 03:52:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 05:36:01]

CQ is committing da patch.

Bot data: {"patchset_id": 280001, "attempt_start_ts": 1479873158901090,
"parent_rev": "9250cda393aaa58e8701f6561398299b8b17c6e7", "commit_rev":
"2c85ada33f8c4fefd63bf5340a40c1d9cf0c5acc"}

[commit-bot: I haz the power, 2016-11-23 05:36:38]

Committed patchset #15 (id:280001)

[commit-bot: I haz the power, 2016-11-23 05:39:13]

Description was changed from

==========
Apply custom property animations

This change enables CSS and Web animations to apply animated
effects on CSS custom properties.

This change involves a restructure of style resolving detailed
in the design doc:
https://docs.google.com/a/chromium.org/document/d/1V27q30H-pQZVbzHCJjdFThBSeu...

BUG=644148
==========

to

==========
Apply custom property animations

This change enables CSS and Web animations to apply animated
effects on CSS custom properties.

This change involves a restructure of style resolving detailed
in the design doc:
https://docs.google.com/a/chromium.org/document/d/1V27q30H-pQZVbzHCJjdFThBSeu...

BUG=644148

Committed: https://crrev.com/99118e5d645f046aa132529f6189a850c5b8ed49
Cr-Commit-Position: refs/heads/master@{#434122}
==========

[commit-bot: I haz the power, 2016-11-23 05:39:15]

Patchset 15 (id:??) landed as
https://crrev.com/99118e5d645f046aa132529f6189a850c5b8ed49
Cr-Commit-Position: refs/heads/master@{#434122}

[kolos1, 2016-11-23 10:03:25]

A revert of this CL (patchset #15 id:280001) has been created in
https://codereview.chromium.org/2521103004/ by kolos@chromium.org.

The reason for reverting is: Some browser tests fail. See crbug.com/668069.

[Michael Achenbach, 2016-11-23 10:42:29]

On 2016/11/23 10:03:25, kolos1 wrote:
> A revert of this CL (patchset #15 id:280001) has been created in
> https://codereview.chromium.org/2521103004/ by mailto:kolos@chromium.org.
> 
> The reason for reverting is: Some browser tests fail. See crbug.com/668069.

This also breaks webkit_unit_tests:
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linu...

(bisected locally)

[Michael Achenbach, 2016-11-23 10:44:42]

On 2016/11/23 10:42:29, machenbach (slow) wrote:
> On 2016/11/23 10:03:25, kolos1 wrote:
> > A revert of this CL (patchset #15 id:280001) has been created in
> > https://codereview.chromium.org/2521103004/ by mailto:kolos@chromium.org.
> > 
> > The reason for reverting is: Some browser tests fail. See crbug.com/668069.
> 
> This also breaks webkit_unit_tests:
>
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linu...
> 
> (bisected locally)

The webkit_unit_tests ran on the trybots but were not affected. Also checked
that locally. The trybots add dcheck_always_on. With that flag it doesn't repro
:/

[alancutter (OOO until 2018), 2016-11-24 02:02:46]

On 2016/11/23 at 10:44:42, machenbach wrote:
> On 2016/11/23 10:42:29, machenbach (slow) wrote:
> > On 2016/11/23 10:03:25, kolos1 wrote:
> > > A revert of this CL (patchset #15 id:280001) has been created in
> > > https://codereview.chromium.org/2521103004/ by mailto:kolos@chromium.org.
> > > 
> > > The reason for reverting is: Some browser tests fail. See
crbug.com/668069.
> > 
> > This also breaks webkit_unit_tests:
> >
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linu...
> > 
> > (bisected locally)
> 
> The webkit_unit_tests ran on the trybots but were not affected. Also checked
that locally. The trybots add dcheck_always_on. With that flag it doesn't repro
:/

Thanks for handling the revert and looking into this. That bit of information
about dcheck_always_on is very useful!