Throw if PaymentRequest() built with 'error' message

Throw if PaymentRequest() built with 'error' message

https://w3c.github.io/browser-payment-api/#constructor

"9. If details contains a value for error, then throw a TypeError."

BUG=648240
Committed: https://crrev.com/067e9cc22c9f46e5d96c3c44890063991049ab1b
Cr-Commit-Position: refs/heads/master@{#435103}

[please use gerrit instead, 2016-11-29 20:48:19]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 20:49:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[please use gerrit instead, 2016-11-29 20:50:24]

Description was changed from

==========
Throw if PaymentRequest() built with 'error' message

BUG=648240
==========

to

==========
Throw if PaymentRequest() built with 'error' message

https://w3c.github.io/browser-payment-api/#constructor

"9. If details contains a value for error, then throw a TypeError."

BUG=648240
==========

[please use gerrit instead, 2016-11-29 20:51:31]

rouslan@chromium.org changed reviewers:
+ foolip@chromium.org, hs1217.lee@samsung.com

[please use gerrit instead, 2016-11-29 20:51:32]

foolip, ptal.

hs1217.lee, fyi.

[foolip, 2016-11-29 21:48:28]

lgtm

https://codereview.chromium.org/2532953006/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/payments/payment-request-interface.html
(right):

https://codereview.chromium.org/2532953006/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/payments/payment-request-interface.html:355: ['If
details contains a null value for error, then throw a TypeError', new
TypeError(), function() {
This will stringify to 'null', but it doesn't hurt to test it. undefined,
however, should be treated as missing and not throw.

[please use gerrit instead, 2016-11-29 21:49:47]

Sending to cq.

https://codereview.chromium.org/2532953006/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/payments/payment-request-interface.html
(right):

https://codereview.chromium.org/2532953006/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/payments/payment-request-interface.html:355: ['If
details contains a null value for error, then throw a TypeError', new
TypeError(), function() {
On 2016/11/29 21:48:28, foolip wrote:
> This will stringify to 'null', but it doesn't hurt to test it. undefined,
> however, should be treated as missing and not throw.

Acknowledged.

[please use gerrit instead, 2016-11-29 21:49:52]

The CQ bit was unchecked by rouslan@chromium.org

[please use gerrit instead, 2016-11-29 21:49:56]

The CQ bit was checked by rouslan@chromium.org

[commit-bot: I haz the power, 2016-11-29 21:50:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 23:08:36]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1480456196216130, "parent_rev":
"8da0656415ae3207e53230e2a849ea1c079fab4d", "commit_rev":
"23f2b528bbd9c2811626d94e21ac63a445c5c6d1"}

[commit-bot: I haz the power, 2016-11-29 23:08:59]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-29 23:12:11]

Description was changed from

==========
Throw if PaymentRequest() built with 'error' message

https://w3c.github.io/browser-payment-api/#constructor

"9. If details contains a value for error, then throw a TypeError."

BUG=648240
==========

to

==========
Throw if PaymentRequest() built with 'error' message

https://w3c.github.io/browser-payment-api/#constructor

"9. If details contains a value for error, then throw a TypeError."

BUG=648240

Committed: https://crrev.com/067e9cc22c9f46e5d96c3c44890063991049ab1b
Cr-Commit-Position: refs/heads/master@{#435103}
==========

[commit-bot: I haz the power, 2016-11-29 23:12:12]

Patchset 1 (id:??) landed as
https://crrev.com/067e9cc22c9f46e5d96c3c44890063991049ab1b
Cr-Commit-Position: refs/heads/master@{#435103}