third_party/WebKit/Source/modules/payments/PaymentRequest.cpp - Issue 2532953006: Throw if PaymentRequest() built with 'error' message

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentRequest.cpp

Issue 2532953006: Throw if PaymentRequest() built with 'error' message (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/payments/PaymentRequest.cpp

diff --git a/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp b/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp

index 10dc9a605e61d45e4a642548af1f2ae46f80e0c5..018a1055b723731007241e03c9ba1486482cb989 100644

--- a/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp

+++ b/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp

@@ -750,8 +750,8 @@ PaymentRequest::PaymentRequest(ScriptState* scriptState,

if (exceptionState.hadException())

return;

- if (details.hasError() && !details.error().isEmpty()) {

- exceptionState.throwTypeError("Error value should be empty");

+ if (details.hasError()) {

+ exceptionState.throwTypeError("Error message not allowed in constructor");

return;

}