Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 2532953005: Update comments in MemoryCoordinator::CreateChildInfoMapEntry (Closed)

Created:
4 years ago by bashi
Modified:
4 years ago
Reviewers:
haraken, chrisha
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update comments in MemoryCoordinator::CreateChildInfoMapEntry There was a TODO comment which said that having a parameter to set memory state at renderers startup. Still we don't have the parameter but we already call OnStateChange() immediately after renderer is ready to communicate. (See MemoryCoordinatorImpl::OnChildAdded()). This is effectively the same so remove the TODO comment. Committed: https://crrev.com/9da8b33e48d84033ad9144237015911543a77c03 Cr-Commit-Position: refs/heads/master@{#434881}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M content/browser/memory/memory_coordinator.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
bashi
PTAL
4 years ago (2016-11-29 01:50:55 UTC) #4
haraken
LGTM
4 years ago (2016-11-29 02:01:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2532953005/1
4 years ago (2016-11-29 03:51:26 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 03:57:16 UTC) #11
commit-bot: I haz the power
4 years ago (2016-11-29 04:00:01 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9da8b33e48d84033ad9144237015911543a77c03
Cr-Commit-Position: refs/heads/master@{#434881}

Powered by Google App Engine
This is Rietveld 408576698