Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Unified Diff: content/browser/memory/memory_coordinator.cc

Issue 2532953005: Update comments in MemoryCoordinator::CreateChildInfoMapEntry (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/memory/memory_coordinator.cc
diff --git a/content/browser/memory/memory_coordinator.cc b/content/browser/memory/memory_coordinator.cc
index cc7436a3e7a293086f55ffdb829a8adf37a5efd8..4317e5cda6f8777473ee19c5fca46e4c46e9ff93 100644
--- a/content/browser/memory/memory_coordinator.cc
+++ b/content/browser/memory/memory_coordinator.cc
@@ -187,8 +187,9 @@ void MemoryCoordinator::CreateChildInfoMapEntry(
std::unique_ptr<MemoryCoordinatorHandleImpl> handle) {
auto& child_info = children_[render_process_id];
// Process always start with normal memory state.
- // TODO(chrisha): Consider having memory state be a startup parameter of
- // child processes, allowing them to be launched in a restricted state.
+ // We'll set renderer's memory state to the current global state when the
+ // corresponding renderer process is ready to communicate. Renderer processes
+ // call AddChild() when they are ready.
child_info.memory_state = mojom::MemoryState::NORMAL;
child_info.handle = std::move(handle);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698