Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1005)

Unified Diff: chrome/browser/ui/input_method/input_method_engine_base.h

Issue 2532803002: Makes delay commitText/setComposition can deal with empty text/composition. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/input_method/input_method_engine_base.h
diff --git a/chrome/browser/ui/input_method/input_method_engine_base.h b/chrome/browser/ui/input_method/input_method_engine_base.h
index b763fe93112065ddae47280ba0a21d01f7343ae1..8d7899a1e33938b871ee45ab3e2bb756e39d2634 100644
--- a/chrome/browser/ui/input_method/input_method_engine_base.h
+++ b/chrome/browser/ui/input_method/input_method_engine_base.h
@@ -177,9 +177,6 @@ class InputMethodEngineBase : virtual public ui::IMEEngineHandlerInterface {
const std::string& component_id,
ui::IMEEngineHandlerInterface::KeyEventDoneCallback& key_data);
- // Called when a key event is handled.
- void KeyEventHandled();
-
protected:
// Notifies InputContextHandler that the composition is changed.
virtual void UpdateComposition(const ui::CompositionText& composition_text,
@@ -229,9 +226,11 @@ class InputMethodEngineBase : virtual public ui::IMEEngineHandlerInterface {
// The composition text to be set from calling input.ime.setComposition API.
ui::CompositionText composition_;
+ bool composition_changed_;
// The text to be committed from calling input.ime.commitText API.
std::string text_;
+ bool commit_text_changed_;
// Indicates whether the IME extension is currently handling a physical key
// event. This is used in CommitText/UpdateCompositionText/etc.
« no previous file with comments | « chrome/browser/ui/input_method/input_method_engine.cc ('k') | chrome/browser/ui/input_method/input_method_engine_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698