Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: chrome/browser/ui/input_method/input_method_engine.cc

Issue 2532803002: Makes delay commitText/setComposition can deal with empty text/composition. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/input_method/input_method_engine_base.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/input_method/input_method_engine.cc
diff --git a/chrome/browser/ui/input_method/input_method_engine.cc b/chrome/browser/ui/input_method/input_method_engine.cc
index a2395de71d6149818400c830b1fb58c3a99d1049..2b459df37f055763f1b43e47911cabbeb2d259dd 100644
--- a/chrome/browser/ui/input_method/input_method_engine.cc
+++ b/chrome/browser/ui/input_method/input_method_engine.cc
@@ -150,6 +150,8 @@ void InputMethodEngine::UpdateComposition(
if (input_context && !handling_key_event_) {
input_context->UpdateCompositionText(composition_, cursor_pos, is_visible);
composition_.Clear();
+ } else {
+ composition_changed_ = true;
}
}
@@ -166,6 +168,8 @@ void InputMethodEngine::CommitTextToInputContext(int context_id,
if (input_context && !handling_key_event_) {
input_context->CommitText(text_);
text_ = "";
+ } else {
+ commit_text_changed_ = true;
}
}
« no previous file with comments | « no previous file | chrome/browser/ui/input_method/input_method_engine_base.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698