Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Unified Diff: components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc

Issue 2532783003: [NTP] Translateable strings for recent tabs and physical web sections. (Closed)
Patch Set: rebase and treib@ comment. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc
diff --git a/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc b/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc
index f6e8084cc6de942a12a0df650b0d057015b87f46..2b0f7ad31f83fc76332b402d30f4a57e7bcc1ba0 100644
--- a/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc
+++ b/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc
@@ -15,6 +15,7 @@
#include "base/strings/utf_string_conversions.h"
#include "base/threading/thread_task_runner_handle.h"
#include "grit/components_strings.h"
+#include "grit/components_strings.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/gfx/image/image.h"
#include "url/gurl.h"
@@ -57,17 +58,16 @@ CategoryStatus PhysicalWebPageSuggestionsProvider::GetCategoryStatus(
CategoryInfo PhysicalWebPageSuggestionsProvider::GetCategoryInfo(
Category category) {
- // TODO(vitaliii): Use the proper string once it has been agreed on.
- // TODO(vitaliii): Use a translateable string. (crbug.com/667764)
// TODO(vitaliii): Implement More action. (crbug.com/667759)
- return CategoryInfo(
- base::ASCIIToUTF16("Physical web pages"),
- ContentSuggestionsCardLayout::FULL_CARD,
- /*has_more_action=*/false,
- /*has_reload_action=*/false,
- /*has_view_all_action=*/false,
- /*show_if_empty=*/false,
- l10n_util::GetStringUTF16(IDS_NTP_SUGGESTIONS_SECTION_EMPTY));
+ return CategoryInfo(l10n_util::GetStringUTF16(
+ IDS_NTP_PHYSICAL_WEB_PAGE_SUGGESTIONS_SECTION_HEADER),
+ ContentSuggestionsCardLayout::FULL_CARD,
+ /*has_more_action=*/false,
+ /*has_reload_action=*/false,
+ /*has_view_all_action=*/false,
+ /*show_if_empty=*/false,
+ l10n_util::GetStringUTF16(
+ IDS_NTP_PHYSICAL_WEB_PAGE_SUGGESTIONS_SECTION_EMPTY));
}
void PhysicalWebPageSuggestionsProvider::DismissSuggestion(

Powered by Google App Engine
This is Rietveld 408576698