Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 2532763003: mus: Simplify generation of memory-buffer ids. (Closed)

Created:
4 years ago by sadrul
Modified:
4 years ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege, Fady Samuel
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mus: Simplify generation of memory-buffer ids. Use an int instead of a StaticAtomicSequenceNumber to generate the ids for the gpu memory buffers. This should be sufficient since this is used only in the same thread. BUG=none Committed: https://crrev.com/c3d66b46c4d6783171d998f9c710d0c98da72a3f Cr-Commit-Position: refs/heads/master@{#434731}

Patch Set 1 #

Patch Set 2 : tot merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -44 lines) Patch
M services/ui/common/BUILD.gn View 1 1 chunk +0 lines, -2 lines 0 comments Download
D services/ui/common/generic_shared_memory_id_generator.h View 1 chunk +0 lines, -18 lines 0 comments Download
D services/ui/common/generic_shared_memory_id_generator.cc View 1 chunk +0 lines, -21 lines 0 comments Download
M services/ui/common/mus_gpu_memory_buffer_manager.h View 3 chunks +4 lines, -1 line 0 comments Download
M services/ui/common/mus_gpu_memory_buffer_manager.cc View 4 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
sadrul
4 years ago (2016-11-26 02:24:10 UTC) #2
sky
LGTM
4 years ago (2016-11-26 16:43:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2532763003/1
4 years ago (2016-11-28 18:00:55 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/313264) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years ago (2016-11-28 18:04:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2532763003/20001
4 years ago (2016-11-28 19:33:08 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-28 21:56:46 UTC) #12
commit-bot: I haz the power
4 years ago (2016-11-28 21:59:24 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c3d66b46c4d6783171d998f9c710d0c98da72a3f
Cr-Commit-Position: refs/heads/master@{#434731}

Powered by Google App Engine
This is Rietveld 408576698