Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Side by Side Diff: services/ui/common/mus_gpu_memory_buffer_manager.cc

Issue 2532763003: mus: Simplify generation of memory-buffer ids. (Closed)
Patch Set: tot merge Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « services/ui/common/mus_gpu_memory_buffer_manager.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "services/ui/common/mus_gpu_memory_buffer_manager.h" 5 #include "services/ui/common/mus_gpu_memory_buffer_manager.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "gpu/ipc/client/gpu_memory_buffer_impl.h" 8 #include "gpu/ipc/client/gpu_memory_buffer_impl.h"
9 #include "gpu/ipc/client/gpu_memory_buffer_impl_shared_memory.h" 9 #include "gpu/ipc/client/gpu_memory_buffer_impl_shared_memory.h"
10 #include "gpu/ipc/common/gpu_memory_buffer_support.h" 10 #include "gpu/ipc/common/gpu_memory_buffer_support.h"
11 #include "services/ui/common/generic_shared_memory_id_generator.h"
12 #include "services/ui/gpu/interfaces/gpu_service_internal.mojom.h" 11 #include "services/ui/gpu/interfaces/gpu_service_internal.mojom.h"
13 12
14 namespace ui { 13 namespace ui {
15 14
16 MusGpuMemoryBufferManager::MusGpuMemoryBufferManager( 15 MusGpuMemoryBufferManager::MusGpuMemoryBufferManager(
17 mojom::GpuServiceInternal* gpu_service, 16 mojom::GpuServiceInternal* gpu_service,
18 int client_id) 17 int client_id)
19 : gpu_service_(gpu_service), client_id_(client_id), weak_factory_(this) {} 18 : gpu_service_(gpu_service), client_id_(client_id), weak_factory_(this) {}
20 19
21 MusGpuMemoryBufferManager::~MusGpuMemoryBufferManager() {} 20 MusGpuMemoryBufferManager::~MusGpuMemoryBufferManager() {}
22 21
23 std::unique_ptr<gfx::GpuMemoryBuffer> 22 std::unique_ptr<gfx::GpuMemoryBuffer>
24 MusGpuMemoryBufferManager::CreateGpuMemoryBuffer( 23 MusGpuMemoryBufferManager::CreateGpuMemoryBuffer(
25 const gfx::Size& size, 24 const gfx::Size& size,
26 gfx::BufferFormat format, 25 gfx::BufferFormat format,
27 gfx::BufferUsage usage, 26 gfx::BufferUsage usage,
28 gpu::SurfaceHandle surface_handle) { 27 gpu::SurfaceHandle surface_handle) {
29 gfx::GpuMemoryBufferId id = GetNextGenericSharedMemoryId(); 28 DCHECK(CalledOnValidThread());
29 gfx::GpuMemoryBufferId id(next_gpu_memory_id_++);
30 const bool is_native = 30 const bool is_native =
31 gpu::IsNativeGpuMemoryBufferConfigurationSupported(format, usage); 31 gpu::IsNativeGpuMemoryBufferConfigurationSupported(format, usage);
32 if (is_native) { 32 if (is_native) {
33 gfx::GpuMemoryBufferHandle handle; 33 gfx::GpuMemoryBufferHandle handle;
34 gpu_service_->CreateGpuMemoryBuffer(id, size, format, usage, client_id_, 34 gpu_service_->CreateGpuMemoryBuffer(id, size, format, usage, client_id_,
35 surface_handle, &handle); 35 surface_handle, &handle);
36 if (handle.is_null()) 36 if (handle.is_null())
37 return nullptr; 37 return nullptr;
38 return gpu::GpuMemoryBufferImpl::CreateFromHandle( 38 return gpu::GpuMemoryBufferImpl::CreateFromHandle(
39 handle, size, format, usage, 39 handle, size, format, usage,
(...skipping 14 matching lines...) Expand all
54 const gfx::GpuMemoryBufferHandle& handle, 54 const gfx::GpuMemoryBufferHandle& handle,
55 const gfx::Size& size, 55 const gfx::Size& size,
56 gfx::BufferFormat format) { 56 gfx::BufferFormat format) {
57 NOTIMPLEMENTED(); 57 NOTIMPLEMENTED();
58 return nullptr; 58 return nullptr;
59 } 59 }
60 60
61 void MusGpuMemoryBufferManager::SetDestructionSyncToken( 61 void MusGpuMemoryBufferManager::SetDestructionSyncToken(
62 gfx::GpuMemoryBuffer* buffer, 62 gfx::GpuMemoryBuffer* buffer,
63 const gpu::SyncToken& sync_token) { 63 const gpu::SyncToken& sync_token) {
64 DCHECK(CalledOnValidThread());
64 static_cast<gpu::GpuMemoryBufferImpl*>(buffer)->set_destruction_sync_token( 65 static_cast<gpu::GpuMemoryBufferImpl*>(buffer)->set_destruction_sync_token(
65 sync_token); 66 sync_token);
66 } 67 }
67 68
68 void MusGpuMemoryBufferManager::DestroyGpuMemoryBuffer( 69 void MusGpuMemoryBufferManager::DestroyGpuMemoryBuffer(
69 gfx::GpuMemoryBufferId id, 70 gfx::GpuMemoryBufferId id,
70 int client_id, 71 int client_id,
71 bool is_native, 72 bool is_native,
72 const gpu::SyncToken& sync_token) { 73 const gpu::SyncToken& sync_token) {
74 DCHECK(CalledOnValidThread());
73 if (is_native) { 75 if (is_native) {
74 gpu_service_->DestroyGpuMemoryBuffer(id, client_id, sync_token); 76 gpu_service_->DestroyGpuMemoryBuffer(id, client_id, sync_token);
75 } 77 }
76 } 78 }
77 79
78 } // namespace ui 80 } // namespace ui
OLDNEW
« no previous file with comments | « services/ui/common/mus_gpu_memory_buffer_manager.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698