Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1411)

Unified Diff: third_party/WebKit/LayoutTests/shadow-dom/slotchange.html

Issue 2532393003: Remove the wrong optimization in replacing a text node with innerHTML (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/shadow-dom/slotchange.html
diff --git a/third_party/WebKit/LayoutTests/shadow-dom/slotchange.html b/third_party/WebKit/LayoutTests/shadow-dom/slotchange.html
index 4ad226efe299da91bd645515265719f2bf85d667..e5387e4f688e5550446b4f039168db01aff49e4d 100644
--- a/third_party/WebKit/LayoutTests/shadow-dom/slotchange.html
+++ b/third_party/WebKit/LayoutTests/shadow-dom/slotchange.html
@@ -309,3 +309,24 @@ async_test((test) => {
n.c1.remove();
}, "slotchange event: Fallback slot's parant slot is assinged to another slot.");
</script>
+
+<div id="test8">
+ <div id="host1">
kochi 2016/11/30 04:20:37 Not critial, but all these subtrees have duplicate
+ <template id="shadowroot" data-mode="open">
+ <slot id="s1"></slot>
+ </template>
+ </div>
+</div>
kochi 2016/11/30 04:20:37 This #test8 subtree isn't used?
hayato 2016/11/30 05:22:55 Done.
+
+<script>
+async_test((test) => {
+ const n = createTestTree(window.test1);
kochi 2016/11/30 04:20:37 nit: other tests use just 'test1', and no local 't
hayato 2016/11/30 05:22:55 Recently, I am using `window.` prefix explicitly f
+ removeWhiteSpaceOnlyTextNodes(n.test1);
+ n.host1.innerHTML = 'hello';
+
+ window.setTimeout(() => {
+ doneIfSlotChange([n.s1], test);
+ n.host1.innerHTML = 'world';
+ }, 0);
+}, 'slotchange event: Replacing a text node with innerHTML.');
+</script>

Powered by Google App Engine
This is Rietveld 408576698