third_party/WebKit/LayoutTests/shadow-dom/slotchange.html - Issue 2532393003: Remove the wrong optimization in replacing a text node with innerHTML

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/shadow-dom/slotchange.html

Issue 2532393003: Remove the wrong optimization in replacing a text node with innerHTML (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/serializers/Serialization.cpp » ('j') | third_party/WebKit/Source/core/editing/serializers/Serialization.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../resources/testharness.js"></script>	2 <script src="../resources/testharness.js"></script>

3 <script src="../resources/testharnessreport.js"></script>	3 <script src="../resources/testharnessreport.js"></script>

4 <script src="resources/shadow-dom.js"></script>	4 <script src="resources/shadow-dom.js"></script>

5	5

6 <div id="test1">	6 <div id="test1">

7 <div id="host1">	7 <div id="host1">

8 <template id="shadowroot" data-mode="open">	8 <template id="shadowroot" data-mode="open">

9 <slot id="s1" name="slot1"></slot>	9 <slot id="s1" name="slot1"></slot>

10 </template>	10 </template>

(...skipping 291 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
302 async_test((test) => {	302 async_test((test) => {

303 let n = createTestTree(test7);	303 let n = createTestTree(test7);

304 removeWhiteSpaceOnlyTextNodes(n.test7);	304 removeWhiteSpaceOnlyTextNodes(n.test7);

305	305

306 document.body.offsetLeft;	306 document.body.offsetLeft;

307 doneIfSlotChange([n.s1, n.s2, n.s3], test);	307 doneIfSlotChange([n.s1, n.s2, n.s3], test);

308	308

309 n.c1.remove();	309 n.c1.remove();

310 }, "slotchange event: Fallback slot's parant slot is assinged to another slot.") ;	310 }, "slotchange event: Fallback slot's parant slot is assinged to another slot.") ;

311 </script>	311 </script>

	312

	313 <div id="test8">

	314 <div id="host1">
	kochi 2016/11/30 04:20:37 Not critial, but all these subtrees have duplicate Not critial, but all these subtrees have duplicate #host1's in document tree.
	315 <template id="shadowroot" data-mode="open">

	316 <slot id="s1"></slot>

	317 </template>

	318 </div>

	319 </div>
	kochi 2016/11/30 04:20:37 This #test8 subtree isn't used? This #test8 subtree isn't used? hayato 2016/11/30 05:22:55 Done. Done.
	320

	321 <script>

	322 async_test((test) => {

	323 const n = createTestTree(window.test1);
	kochi 2016/11/30 04:20:37 nit: other tests use just 'test1', and no local 't nit: other tests use just 'test1', and no local 'test1' in this function, so 'window.' is unnecessary? It's fine if this is to avoid confusion with the next line ('n.test1'). Or should this be 'test8'? hayato 2016/11/30 05:22:55 Recently, I am using `window.` prefix explicitly f Show quoted text On 2016/11/30 at 04:20:37, kochi wrote: > nit: other tests use just 'test1', and no local 'test1' in this function, so 'window.' is unnecessary? It's fine if this is to avoid confusion with the next line ('n.test1'). > > Or should this be 'test8'? Recently, I am using `window.` prefix explicitly for new code to suppress eslint's warnings. Yeah, it is inconsistent within this file, but that might be okay.
	324 removeWhiteSpaceOnlyTextNodes(n.test1);

	325 n.host1.innerHTML = 'hello';

	326

	327 window.setTimeout(() => {

	328 doneIfSlotChange([n.s1], test);

	329 n.host1.innerHTML = 'world';

	330 }, 0);

	331 }, 'slotchange event: Replacing a text node with innerHTML.');

	332 </script>

OLD	NEW